Why was there a run error with some functions?

Question

MainActivity mActivity = new MainActivity();
mActivity.countRecords();

The Way I Used to call function countRecords() Which it was inside OnClickListenerCreateStudent class But I found the message when the button is pressed but with this a way no problems ((MainActivity)context).countRecords(); What is the difference between them now ?

package com.example.train1;
    import android.app.Activity;
    import android.os.Bundle;
    import android.view.Menu;
    import android.view.MenuItem;
    import android.widget.Button;
    import android.widget.TextView;


    public class MainActivity extends Activity {
        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);
            Button buttonCreateLocation = (Button) findViewById(R.id.buttonCreateStudent);
            buttonCreateLocation.setOnClickListener(new OnClickListenerCreateStudent());
            countRecords();
        }


        public void countRecords() {
            int recordCount = new TableControllerStudent(this).count(); 
            TextView textViewRecordCount = (TextView) findViewById(R.id.textViewRecordCount);
            textViewRecordCount.setText(recordCount + " records found.");
        }


        @Override
        public boolean onCreateOptionsMenu(Menu menu) {
            // Inflate the menu; this adds items to the action bar if it is present.
            getMenuInflater().inflate(R.menu.main, menu);
            return true;
        }


        @Override
        public boolean onOptionsItemSelected(MenuItem item) {
            // Handle action bar item clicks here. The action bar will
            // automatically handle clicks on the Home/Up button, so long
            // as you specify a parent activity in AndroidManifest.xml.
            int id = item.getItemId();
            if (id == R.id.action_settings) {
                return true;
            }
            return super.onOptionsItemSelected(item);
        }
}





package com.example.train1;
import android.app.AlertDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.EditText;
import android.widget.Toast;


    import android.app.Activity;


    public class OnClickListenerCreateStudent implements View.OnClickListener {


             //MainActivity M_activity;
        //MainActivity mActivity// = new MainActivity();

        @Override
        public void onClick(View view) {

        //M_activity = new MainActivity();

          final Context context = view.getContext();

          LayoutInflater inflater = (LayoutInflater)context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
          final View formElementsView = inflater.inflate(R.layout.student_input_form, null, false);

          final EditText editTextStudentFirstname = (EditText) formElementsView.findViewById(R.id.editTextStudentFirstname);
          final EditText editTextStudentEmail = (EditText) formElementsView.findViewById(R.id.editTextStudentEmail);

          new AlertDialog.Builder(context).setView(formElementsView).setTitle("Create Student")
          .setPositiveButton("Add",
              new DialogInterface.OnClickListener() {
             // countRecords();

                  public void onClick(DialogInterface dialog, int id) {

                      String studentFirstname = editTextStudentFirstname.getText().toString();
                      String studentEmail = editTextStudentEmail.getText().toString();

                      ObjectStudent objectStudent = new ObjectStudent();
                      objectStudent.firstname= studentFirstname;
                      objectStudent.email= studentEmail;
                      // call to table controller stud and put objectData
                      boolean createSuccessful = new TableControllerStudent(context).create(objectStudent);
                      if(createSuccessful){
                            Toast.makeText(context, "Student information was saved.", Toast.LENGTH_SHORT).show();
                        }else{
                            Toast.makeText(context, "Unable to save student information.", Toast.LENGTH_SHORT).show();
                        }




                    ((MainActivity)context).countRecords();

                      MainActivity mActivity = new MainActivity();
                      mActivity.countRecords();


                      //((MainActivity)).
                      dialog.cancel();

                  }
              }).show();

          // Toast.makeText(context," "+context , Toast.LENGTH_LONG).show();

        }





      public class ObjectStudent {
            int id;
            String firstname;
            String email;

            public ObjectStudent(){

           }

       }

      // class End

    }

Answer 1

Never create your activities with the constructor, they're bound to not be initialized correctly sooner or later.

Create the Activity via the Intent, as in the docs:

Intent intent = new Intent(this, DisplayMessageActivity.class);