How to return true or false in this scenario?

Question

Here is a my code

   public boolean changePassword(String password, String id) {

    try {

        StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
        StrictMode.setThreadPolicy(policy);

        Class.forName("com.mysql.jdbc.Driver");
        Connection conn = DriverManager.getConnection(DB_URL, DBuser, DBpassword);


        Statement st = conn.createStatement();
        String updateQuery = "update teacher_registration set password="+password+"where teacher_id="+id;
        ResultSet rs = st.executeQuery(updateQuery);

        if(rs!=null){
            return true;
        }else{
            return false;
        }
    } catch (Exception e) {
        e.printStackTrace();
    }

}

I want to return true if rs is not null else return false.

But i am getting an error at the closing bracket of this method. It is asking me to return a true or false again even if I did so in the try catch block earlier.

This is my first time working with java.

Please HELP!

You shouldn't `return` from a `try` block. See http://stackoverflow.com/questions/2309964/multiple-returns-which-one-sets-the-final-return-value — bradimus, Jul 22 '16 at 20:39
Yes. I changed that. Now i need to know if my update query worked or not. — walimbeakshay, Jul 22 '16 at 20:52

score 3 · Answer 1 · answered Jul 22 '16 at 20:35

Do something like this

public boolean changePassword(String password, String id) {
  boolean result = false;

try {

    StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
    StrictMode.setThreadPolicy(policy);

    Class.forName("com.mysql.jdbc.Driver");
    Connection conn = DriverManager.getConnection(DB_URL, DBuser, DBpassword);


    Statement st = conn.createStatement();
    String updateQuery = "update teacher_registration set password="+password+"where teacher_id="+id;
    ResultSet rs = st.executeQuery(updateQuery);

    if(rs!=null){
        result = true;
    }else{
        result = false;
    }
} catch (Exception e) {
    e.printStackTrace();
}
 return result;
}

No, this didn't work..... If I set result=true initially, it will return true even if password does not change... — walimbeakshay, Jul 22 '16 at 21:16
@walimbeakshay You do not initialize to the value that indicates success or "work done". You initialize to the value that indicates failure or "work not yet done". — Basil Bourque, Jul 23 '16 at 03:37

score 1 · Answer 2 · answered Jul 22 '16 at 20:34

1

Your mistake is you return the value in the try block. If something fails, you won't return anything. Try moving the return statement outside the try block or add a return false; after the catch block.

answered Jul 22 '16 at 20:34

Michael Barz

276
2
11

I need to know first if the query has worked or not. Cause its not updating the table. – walimbeakshay Jul 22 '16 at 20:48

Iman Irajian · Accepted Answer · 2016-07-24T19:39:31.717

I think update query pieces don't combine together well.

In this case 'where' become a part of your password (at the end).

Try this:

String updateQuery = "update teacher_registration set password="+password+" where teacher_id="+id;

Plus you can move your condition into catch block or do even better as show below.

Full version of your code:

public boolean changePassword(String password, String id) {

    try {

        StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
        StrictMode.setThreadPolicy(policy);

        Class.forName("com.mysql.jdbc.Driver");
        Connection conn = DriverManager.getConnection(DB_URL, DBuser, DBpassword);


        Statement st = conn.createStatement();
        String updateQuery = "update teacher_registration set password="+password+" where teacher_id="+id;
        ResultSet rs = st.executeQuery(updateQuery);
        if(rs!=null){
            return true;
        }

    } catch (Exception e) {
        e.printStackTrace();
        return false;
    }

}

@walimbeakshay: Good luck. – Iman Irajian Jul 25 '16 at 18:48 — Iman Irajian, Jul 25 '16 at 18:48

score 0 · Answer 4 · answered Jul 22 '16 at 20:35

0

If there is an exception generated in your try block, your return statements will not be reached. After catching the exception, you simply need to return a value. I assume that you return true if the change is successful, so return false if there is an exception.

try{
    // Your code
} catch (Exception e) {
    e.printStackTrace();
}
return false;

answered Jul 22 '16 at 20:35

mattm

5,851
11
47
77

I think this is working, but now i am not sure if checking rs not null is really giving me the result. I mean its not changing the password at all. – walimbeakshay Jul 22 '16 at 20:46

How to return true or false in this scenario?

4 Answers4