1

I have been taking a class at Coursera and we had an assignment which was to count the number of comparisons QuickSort does on a 10,000 size array a numbers.

#include <stdio.h>
#define SIZE 10000

int ComparsionCount = 0;

void swap(int a[], int i, int j) {
        int temp = a[j];
        a[j] = a[i];
        a[i] = temp;
}
int partition(int a[], int l, int r){
        int p = a[l];
        int i = l + 1;
        int j;
        for (j = l + 1; j <= r; j++) {
            if (a[j] < p) {
                swap(a, j, i);
                i++;
            }
        }
        swap(a, l, i - 1);
        return (i - 1);
}
void add(int i) {
    ComparsionCount += i;
}

int QuickSort(int a[], int l, int r){
    int pivot;
    if (r > 1) {
        add(r - 1);
        pivot = partition(a, l, r);
        QuickSort(a, l, pivot - 1);
        QuickSort(a, pivot + 1, r);
    }
    return pivot;
}

int main() {
    FILE *fr;
    int arr[SIZE];
    int i = 0;
    int elapsed_seconds;
    char line[80];

    fr = fopen("QuickSort.txt", "r");
    while (fgets(line, 80, fr) != NULL)
    {
         /* get a line, up to 80 chars from fr.  done if NULL */
         sscanf (line, "%ld", &elapsed_seconds);
         /* convert the string to a int */
         arr[i] = atoi(line);
         i++;
    }
    fclose(fr);  /* close the file prior to exiting the routine */
    printf("%d\n",QuickSort(arr,0,SIZE-1));
}

I am getting an segmentation error. I have identified that the problem lies in two recursive calls of QuickSort.

I have no idea of how to solve this problem,your help would be appreciated a lot Thanks in advance.

kiner_shah
  • 3,939
  • 7
  • 23
  • 37
Gent Binaku
  • 39
  • 2
  • 12
  • 2
    `QuickSort(arr,0,SIZE-1));` Why are you passing `SIZE-1`?It is the maximum size of the array.You need to pass the last index at which an element is present, maybe you want to pass `i-1` – Gaurav Sehgal Jul 24 '16 at 03:49

1 Answers1

0

I think you should add the code in the partition function like this:

for (j = l + 1; j <= r; j++) {
    count++;
    if (a[j] < p) {
    ...
}

Note: count is a global variable initialized to 0.

kiner_shah
  • 3,939
  • 7
  • 23
  • 37