Android getSharedPreferences is not working inside a method

Question

public static void GetAllPoints(final IGetAllPointsCallBack callBack) {    
    SharedPreferences entity =  getSharedPreferences("settings",MODE_PRIVATE);
    String savedValue = entity.getString("entityGUID",null);
}

getSharedPreferences is not working here, is there a way to call it inside my method while I save its value in another class ?

I am saving my preferences like this:

EntityType selectedItem = ApplicationController.entities.get(which);
SharedPreferences.Editor savedValue = getSharedPreferences("settings",MODE_PRIVATE).edit();
savedValue.putString("entityGUID", String.valueOf(selectedItem.EntityGUID));
savedValue.apply();

I needed to make my method static is because I am accessing it from another class:

    public void showAllSpots()
    {
     DataService.GetAllPoints(newDataService.IGetAllChargingPointsCallBack() {
     @Override
     public void Success(ArrayList<ChargingSpot> chargingSpots) {
      //
     }

     });
    }

what is error/output you get?? are you sure you have saved data inside sharedpreference — SaravInfern, Aug 02 '16 at 06:36
Possible duplicate of ["Non-static method cannot be referenced from a static context" error](http://stackoverflow.com/questions/4922145/non-static-method-cannot-be-referenced-from-a-static-context-error) — OneCricketeer, Aug 02 '16 at 06:38
Same thing it didn't work, the getSharedPreferences cannot be defined inside my method — Abdelrahman Manna, Aug 02 '16 at 06:40
Right... this question is a duplicate. That is your problem... `public static void` needs to be `public void`. You are using static variables, and that is just the incorrect way to do things in Android in most cases — OneCricketeer, Aug 02 '16 at 06:41
Because your method is static you cannot access the method (which is not static) — MatF, Aug 02 '16 at 06:41
I had to make it static because I am using it in different classes, but I also tried to remove static and also didn't work — Abdelrahman Manna, Aug 02 '16 at 06:44

score 2 · Answer 1 · answered Aug 02 '16 at 06:52

You need to either change your method so that it is not static OR you need to supply Context as one of the arguments to this method and then your method will look like:

public static void GetAllPoints(final Context context, final IGetAllPointsCallBack callBack) {    
    SharedPreferences entity =  context.getSharedPreferences("settings",Context.MODE_PRIVATE);
    String savedValue = entity.getString("entityGUID",null);
}

I hope this helps.

How is this different from my solution? – Hadi Satrio Aug 02 '16 at 06:53 — Hadi Satrio, Aug 02 '16 at 06:53

Hadi Satrio · Accepted Answer · 2016-08-02T06:48:59.210

0

As per the official docs for Context, getSharedPreferences(...) is NOT static. Therefore you won't be able to access it within a static method.

Try defining your method like below and it should work:

public void GetAllPoints(final IGetAllPointsCallBack callBack) {    
    SharedPreferences entity =  getSharedPreferences("settings",MODE_PRIVATE);
    String savedValue = entity.getString("entityGUID",null);
}

EDIT: Upon examining your comment reply, I noticed your requirement of keeping GetAllPoints(...) static. A workaround would be passing the calling Context and call getSharedPreferences(...) from it:

public void GetAllPoints(final Context context, final IGetAllPointsCallBack callBack) {    
    SharedPreferences entity =  context.getSharedPreferences("settings",MODE_PRIVATE);
    String savedValue = entity.getString("entityGUID",null);
}

edited Aug 02 '16 at 06:48

answered Aug 02 '16 at 06:43

Hadi Satrio

4,272
2
24
45

but when I remove static, the method can't be accessed from the other classes right ? – Abdelrahman Manna Aug 02 '16 at 06:48
Well it won't be _directly_ accessible without an instance of that class, sure. I've edited my answer. – Hadi Satrio Aug 02 '16 at 06:51
Thanks it worked, one last question I edited my above question is how to reflect the change on the method I call ? – Abdelrahman Manna Aug 02 '16 at 06:58
Hmm.. That depends: Where do you place that `showAllSpots(...)` in? Is it from an `Activity`? or perhaps another non-`Context` based class? – Hadi Satrio Aug 02 '16 at 07:05

Android getSharedPreferences is not working inside a method

2 Answers2