Default case always getting executed of Switch

Question

I have Drupal 7 site. I have the following Switch structure.

$day = (int)$node->field_hours_count[LANGUAGE_NONE][0]['value'];
switch ($day) {
    case 1:
        constructNode($node,"sunday");
        echo 'node updated successfuly';
        break;
    case 2:
        constructNode($node,"monday");
        echo 'node updated successfuly';
        break;
    case 3:
        constructNode($node,"tuesday");
        echo 'node updated successfuly';
        break;
    default :
       echo 'no node found'; 
       exit();
   }

Here constructNode() is a function which accepts two parameters.

function constructNode($node,$dayOfWeek)
{
   //core operation
  return $node;
}

Issue is suppose $day =1 then case 1 is executed plus default case. For every value of $day, default case is getting executed.

php - version v 5.5.12

How do I prevent this?

What *is* the value of `$day` when the default statement gets executed? — TZHX, Aug 02 '16 at 11:24
using `print_r($day)`, I am checking $day & it printing the right value. If passed value is 1 then it prints 1, if 2 then 2 & so on. There is nothing wrong with $day. I have cross-checked it for 2-3 times on it — Kgn-web, Aug 02 '16 at 11:25
Try setting $day manually for testing purposes. Does it work? — Julian Kuchlbauer, Aug 02 '16 at 11:27
So you're saying in the default case, you're printing `$day` and getting a value of 1,2 or 3? — TZHX, Aug 02 '16 at 11:27
@user4035, if that is the case then case 1: should NOT be executed but the issue is that Default is getting executed along with the right case — Kgn-web, Aug 02 '16 at 11:28
@pkhode I tried your code on my machine. Setting $day manually to 1 executes case 1. — user4035, Aug 02 '16 at 11:30
i think `break;` is missing from the default statement. http://stackoverflow.com/questions/11904108/php-switch-case-default — Jees K Denny, Aug 02 '16 at 11:31

score 1 · Answer 1 · answered Aug 02 '16 at 11:36

1

Issue is suppose $day = 1 then case 1 is executed plus default case. For every value of $day, default case is getting executed.

That's not how Switch statements work. After any case is executed, the break exits the statement so nothing else will be matched. The only possible way this is happening is if you're calling the Switch statement twice with different values.

answered Aug 02 '16 at 11:36

mister martin

6,197
4
30
63

Mate, I know that but since I am facing such strange thing hence posted here – Kgn-web Aug 02 '16 at 11:40
@pkhode no one can magically figure out what you need to fix based on the example you provided (which works perfectly). – mister martin Aug 02 '16 at 11:44

Default case always getting executed of Switch

1 Answers1