Visual Basic 2015 (Visual Studio)

Question

I'm trying to create a Login Form using Visual Basic 2015 in Visual Studio. I've followed the instructions from a video that I've watched, however, an error occurred when I tried to run the code.

Here's the codes I've done so far:

---

Private Sub picgo1_Click(sender As Object, e As EventArgs) Handles picgo1.Click

 openConn()

        Dim dr As SqlDataReader
        Dim cmd As SqlCommand
        Dim sqlsyntax As String
        cmd = New SqlCommand
        cmd.CommandType = CommandType.Text
        cmd.Connection = conn
        sqlsyntax = "select * from tblusers where user = '" & txtuser.Text & "' and pass = '" & txtpass.Text & "'"
        cmd.CommandText = sqlsyntax
        dr = cmd.ExecuteReader()

If dr.HasRows Then

 MsgBox("Access Granted! Welcome '" & txtuser.Text & "'")

Else

 MsgBox("Access Denied! Incorrect Username or Password!")

End If

 conn.Close()

 cmd.Dispose()

    End Sub

---

Another for Module

Imports System.Data.SqlClient

Module ModuleConnections
    Public conn As SqlConnection

    Sub openConn()
        Try
            conn = New SqlConnection("Data Source=E:\HRIMS\HRIMS V1.0\WINDOWSAPPLICATION2\HRIMSDB.MDF;Integrated security=True")
            If conn.State = ConnectionState.Closed Then
                conn.Open()
            End If
        Catch ex As Exception
            MsgBox("Connecting to Database Failed" & ex.ToString)
        End Try
    End Sub

End Module

---

When I tried to run the form, here is the error I'm getting. Then when I pressed ok, it points me to this line.

I'm still trying to learn, so please don't be too hard on me :D

Thank you in advance.

Answer 1

Try:

Public conn As SqlConnection

Public Sub openConn()
        conn = New SqlConnection(CONNECTIONSTRING)
        If conn.State = ConnectionState.Closed Then
            conn.Open()
        End If
        Return conn
End Function

Login code:

 Using cmd As New SqlCommand("SELECT * 
                             FROM tblusers 
                             WHERE user = @userName 
                             AND pass = @userPass", openConn)
   'Parameterize your query to be safe from SQL Injection
   cmd.Parameters.AddWithValue("@userName", txtuser.Text)
   cmd.Parameters.AddWithValue("@userPass", txtpass.Text)
   Using rdr As SqlDataReader = cmd.ExecuteReader(CommandBehavior.SingleResult)
       Dim Login As Object = 0
       If rdr.HasRows Then
           rdr.Read
           Login = rdr(Login)
       End If
       If Login = Nothing Then
           MsgBox("Access Denied! Incorrect Username or Password!")
       Else
           'MsgBox("Access Granted! Welcome '" & txtuser.Text & "'")
           MsgBox(String.Format("Access Granted! Welcome {0}!", txtuser.text)
       End If
    End Using
End Using