getSupportFragmentManager() undefined in adapter when using AppCompatActivity

Question

I have an activity (MainActivity) which extends AppCompatActivity because I am using some of the material design elements in my app.

I then have an array adapter with a few fields and a button. This adapter has a separate view and is injected into my MainActivity layout.

When I click the button on the adapter view, I want to open a new fragment which displays a bunch of text, however, I can't seem to do this and I think it is because I am not extending FragmentActivity in my MainActivity? I read on another post that I should be able to extend AppCompatActivity and still be able to reference the fragment manager...here is my code to open the fragment:

In my custom array adapter, onClick() of a button:

holder.desc.setOnClickListener(new View.OnClickListener() {
  @Override
  public void onClick(View view) {
      JobDescFragment fragment= new JobDescFragment();
      FragmentTransaction transaction =      getSupportFragmentManager().beginTransaction();
      transaction.replace(R.id.fragment_container, fragment);
      transaction.addToBackStack(null);  
      transaction.commit();
  }
});

The error I get is that it cannot resolve getSupportFragmentManager(). What am I doing wrong?

I am importing android.support.v4.app.Fragment and .FragmentManager in my adapter.

Thanks in advance for the help!

EDIT:

<merge
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools">

    <com.lorentzos.flingswipe.SwipeFlingAdapterView
        android:id="@+id/frame"
        android:background="@color/laborswipe_lightgray"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        tools:context=".MainActivity"
        android:layout_gravity="top"   />

    <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:id="@+id/fragment_container"
        android:layout_width="match_parent"
        android:layout_height="match_parent" />

</merge>

Share your layout file which contains fragment_container may help — anhtuannd, Aug 05 '16 at 03:39

score 21 · Answer 1 · answered Aug 05 '16 at 04:34

21

you can try this

FragmentTransaction ft = ((AppCompatActivity) mContext).getSupportFragmentManager()
                        .beginTransaction();

answered Aug 05 '16 at 04:34

Jenis Kasundra

583
9
19

score 6 · Answer 2 · answered May 18 '18 at 11:24

In kotlin it will be like this for example. I have tried it and it work perfectly

val dialog = IntervAddFragment()//The fragment that u want to open for example
       val ft = (context as AppCompatActivity).supportFragmentManager.beginTransaction()
        dialog.show(ft, ContentValues.TAG)

score 4 · Answer 3 · answered Oct 14 '16 at 05:48

Hi this is simple just pass the reference of YourParent Activity Just use the snippet like this below in Your Adapter class to open fragment

Fragment fragment = new YourFragment();
FragmentManager fm = ((MainActivity) mContext).getSupportFragmentManager();
                FragmentTransaction ft = fm.beginTransaction();
                ft.add(R.id.frame_container, fragment);
                ft.commit();

score 1 · Answer 4 · answered Aug 05 '16 at 03:14

1

in adapter use

appCompatActivity object instead of context

it will work

answered Aug 05 '16 at 03:14

Akash kv

429
4
13

Where in my adapter do I use that? I can't extend it, so I am trying it like this ((AppCompatActivity)context).getSupportFragmentManager() ? – user2573690 Aug 05 '16 at 03:15
i will add another answer check it.. use that way – Akash kv Aug 05 '16 at 03:17
The context within ArrayAdapter may be ApplicationContext, so casting it is very risky. – anhtuannd Aug 05 '16 at 03:27

score 0 · Answer 5 · answered Aug 05 '16 at 03:02

0

pass context in adapter and use

context.getSupportFragmentManager().beginTransaction();

answered Aug 05 '16 at 03:02

Akash kv

429
4
13

I tried this but no luck! It still says it cannot resolve getSupportFragmentManager(). – user2573690 Aug 05 '16 at 03:04
use AppCompatActivity appCompatActivity; – Akash kv Aug 05 '16 at 03:14

Akash kv · Answer 6 · 2016-08-05T03:27:21.840

avoid unwanted codes

 public class AdapterRecyclerViewDoc extends RecyclerView.Adapter<AdapterRecyclerViewDoc.ShareDocViewHolder> {
        ArrayList<ModelDoc> arrayList;

        AppCompatActivity appCompatActivity;

        public AdapterRecyclerViewDoc(ArrayList<ModelDoc> arrayList, AppCompatActivity appCompatActivity) {
            this.arrayList=arrayList;
            this.appCompatActivity=appCompatActivity;
        }

        @Override
        public ShareDocViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {

            View v = LayoutInflater.from(parent.getContext()).inflate
                    (R.layout.recyclerview_item_doc, parent, false);
            ShareDocViewHolder eventViewHolder = new ShareDocViewHolder(v);
            this.appCompatActivity.getSupportFragmentManager();
             return eventViewHolder;
        }

How does that code open the fragment? If I do this.appCompatActivity I still can't get the fragment manager. Doing this ((FragmentActivity)mContext).getSupportFragmentManager().beginTransaction() works to get around the cannot resolve error, but I still dont see the fragment opening. — user2573690, Aug 05 '16 at 03:24

score 0 · Answer 7 · answered Aug 05 '16 at 04:28

To make the code more flexible and separate logic you should understand responsibilities of your components. It is clear that your Adapter should not know about the Fragment and what is base class of Activity. So what should you do?

In your Activity you should set a listener to item clicked event inside adapter:

public class YourActivity extends AppCompatActivity {

     @Override
     protected void onCreate(Bundle savedInstanceState) {
          super.onCreate(savedInstanceState);
          setContentView(R.layout.activity_your);
          //... some findViewById, etc.
          YourAdapter adapter = new YourAdapter(this, data, new OnDetailsRequestListener(){
               public void onDetailsRequested(int itemId){
                    DetailsFragment fragment = DetailsFragment.newInstance(itemId);
                    getSupportFragmentManager().beginTransaction()
                         .replace(R.id.fragment_container, fragment)
                         .addToBackStack(null)
                         .commit();
               });
            //... recyclerView.setAdapter ... etc.

     }

 public interface onDetailsRequestListener{
      void onDetailsRequestLister(int itemId);//here could be whatever you want, itemId, details, whatever...
 }
}

And inside your adapter you would have:

//...
    public AdapterConstructor(Context context, ArrayList data, YourActivity.OnDetailsRequestListener detailsRequestListener) {
       this.data = data;
       this.context = context;
       this.detailsRequestListener = detailsRequestListener;
       //...
    }
    //Inside bindView
    holder.desc.setTag(position);
    holder.desc.setOnClickListener(new View.OnClickListener() {
       @Override
       public void onClick(View view) {
          int position = (int)view.getTag();
          int itemId = data.get(position).getId();
          detailsRequestListener.onDetailsRequested(itemId);
       }
    });

Thanks for the help! I am creating the adapter in an AsyncTask that is part of my main activity, I tried to adapt your code to move what is in the onCreate to the onPostExecute section of my AsyncTask but this does not work, it cannot resolve the OnDetailsRequestListener method which I created in my activity. Any ideas? — user2573690, Aug 07 '16 at 15:54

score 0 · Answer 8 · answered Mar 18 '17 at 10:47

From your class

  YourAdapter=new YourAdapter(context, list, YourClass.this.getSupportFragmentManager)

Adapter

  public Adapter(context, list, FragmentManager manager){ 
  this.manager=manager;

Action

 FragmentTransaction ft = fragmentcontext.beginTransaction();
            SlideshowDialogFragment newFragment = SlideshowDialogFragment.newInstance();
            newFragment.setArguments(bundle);
            newFragment.show(ft, "slideshow");

score -2 · Answer 9 · edited Jan 28 '17 at 20:18

-2

FragmentTransaction trans =((FragmentActivity)context).getSupportFragmentManager()
                        .beginTransaction();

If you try this, you will see it work.

edited Jan 28 '17 at 20:18

Dan Lowe

51,713
20
123
112

answered Jan 28 '17 at 19:22

Sayeimehtap

1
1

getSupportFragmentManager() undefined in adapter when using AppCompatActivity

EDIT:

9 Answers9