app.use got error of Can\'t set headers after they are sent error

Question

In my app.js I do this

app.use(function(req, res, next){

  if(!req.user){
    res.redirect('/login_');
  }
  next();
})

I don't see anything wrong and in route/index.js I do

router.get('/login_', function(req, res) {
    res.render('login', { user : req.user });
});

But I got error of throw new Error('Can\'t set headers after they are sent.'); I know this is caused by the request is not ended but what's wrong with my code above? clueless with this error.

full code of route/index.js http://pastebin.com/kT2QfnjL

Can you share complete code of yours ? I do not see any mistake in provided code... — Rayon, Aug 06 '16 at 15:17

score 2 · Answer 1 · edited May 23 '17 at 12:08

2

This is caused because when the code tries to send the response after the response is sent.

Reference:

Error: Can't set headers after they are sent to the client

edited May 23 '17 at 12:08

Community

1
1

answered Aug 06 '16 at 15:29

Shankar Shastri

1,134
11
18

I know but what should I do? – Maria Jane Aug 07 '16 at 03:43

score 1 · Answer 2 · answered Aug 06 '16 at 15:29

1

return and redirect to solve this issue

app.use(function(req, res, next){

  if(!req.user){
    return res.redirect('/login_');
  }
  next();
})

answered Aug 06 '16 at 15:29

Lekhnath

4,532
6
36
62

app.use got error of Can\'t set headers after they are sent error

2 Answers2