Remove an item from a custom list

Question

I have a List<Fill> items

Here is the Fill class :

public class Fill
{
    public string arret { get; set;}
    public string ligneSens { get; set;}
}

How can I remove an item from this List using the string value arret and ligneSens ?

Example :

void OnDelete(object sender, EventArgs e, string arretName, string ligneSensName)
{
    var aFill = new Fill
    {
        arret = arretName,
        ligneSens = ligneSensName
    };

    items.Remove(aFill); //<--- this doesn't work
}

Sorry for the title of the post I didn't know how to ask that.

Answer 1

You should override the Equals and GetHashCode methods of object. When you call the Remove on a reference type (classes) then it will look for one by it's Equals method.

public class Fill
{
    public string arret { get; set; }
    public string ligneSens { get; set; }

    public override bool Equals(object obj)
    {
        var other = obj as Fill;
        if(other == null)
            return false;

        return other.arret == arret && other.ligneSens == ligneSens;
    }

    public override int GetHashCode()
    {
        return arret.GetHashCode() ^
               ligneSens.GetHashcode();
    }
}

For what are the best practices on GetHashCode() overriding search online, there are many questions about it

Another way, is to specifically say what to remove by passing a predicate to evaluate for each item in the collection:

items.RemoveAll(item => item.arret = arretName &&  
                        item.ligneSens == ligneSensName);

Answer 2

You have to use RemoveAll() for that, currently you are passing a newly created object, about which items does not have information, because it is a new reference not the same reference :

void OnDelete(object sender, EventArgs e, string arretName, string ligneSensName)
{
   items.RemoveAll(item => item.arret == arretName &&  item.ligneSens == ligneSensName);
}

Answer 3

Use List API RemoveAll

items.RemoveAll(x => x.arret.Equals("value") && x.ligneSensName.Equals("ligneValue"));