Get label from cell - swift

Question

Here is my code:

var username: String!

func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
    let cell : MainCell! = tableView.dequeueReusableCellWithIdentifier("MainCell") as! MainCell

    username = usernameLabel.text
    cell.button.userInteractionEnabled = true
    let tapButton = UITapGestureRecognizer(target: self, action: #selector(ViewController.tapLabel(_:)))
    cell.button.addGestureRecognizer(tapButton)

    return cell as MainCell
}

func tapButton(sender:UITapGestureRecognizer) {
    print(username) //this prints the wrong cell... why?
}

i want to be able to print the variable username but it prints the wrong username for the cell when i press on the button. why is that and how can i fix it?

Why do you expect the correct value to be printed? `cellForRowAtIndexPath` is called many times so `username` will only have the value of the last referenced cell. But you try to print that value for every cell. — rmaddy, Aug 13 '16 at 05:03
why you used getsure for button , no need you can directly get the index — Anbu.Karthik, Aug 13 '16 at 05:05

score 1 · Answer 1 · answered Aug 13 '16 at 05:09

1

add tag in cellForRowAtIndex

 func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
    let cell : MainCell! = tableView.dequeueReusableCellWithIdentifier("MainCell") as! MainCell

     cell.button.userInteractionEnabled = true
    cell.button.setTitle( usernameLabel.text, forState: .Normal)
     cell.button.tag = indexPath.row
     cell.button.addTarget(self, action: #selector(ViewController.tapButton(_:)), forControlEvents: .TouchUpInside)

    return cell as MainCell
}

get action as

func tapButton(sender: UIButton!) 
{
   username =  sender.titleLabel.text
    print(username)  
}

answered Aug 13 '16 at 05:09

Anbu.Karthik

82,064
23
174
143

it means your cell prints the last value only, check the updated answer you get correct userName on click – Anbu.Karthik Aug 13 '16 at 05:13
It's poor practice to set a view's tag based on the cell's index path. That only works if there is one section and the rows are static (no adding, deleting, or reordering). – rmaddy Aug 13 '16 at 05:15
what's titleLabel.text? – johnniexo88 Aug 13 '16 at 05:18
it is a UIButton property you can get the current index of text using button click, – Anbu.Karthik Aug 13 '16 at 05:23
@rmaddy - I agree brother, can you give any other suggest for this – Anbu.Karthik Aug 13 '16 at 05:24
`sender.` gives me this error: [UITapGestureRecognizer tag]: unrecognized selector sent to instance 0x7f……. *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UITapGestureRecognizer tag]: unrecognized selector sent to instance 0x7f…... – johnniexo88 Aug 13 '16 at 05:34
@johnniexo88 - can you update the question with my answer – Anbu.Karthik Aug 13 '16 at 05:35
@johnniexo88 - Something Mismatched bro, can you update the question once with answer – Anbu.Karthik Aug 13 '16 at 05:39

score 1 · Answer 2 · answered Aug 13 '16 at 05:49

you should implement action button in MainCell . you have available with username and this is best practice ;)

class MainCell: UITableViewCell {
   @IBOutlet weak var usernameLabel: UITextView!

   func tabButton(sender: AnyObject) {
       print(usernameLabel.text)
   } 
}

score 0 · Answer 3 · answered Aug 13 '16 at 05:09

0

It will print the latest value stored in username because every indexPath of cell, it will update the value in username & at the end will give you the latest updated value no matter which cell you are tapping

answered Aug 13 '16 at 05:09

Anupam Mishra

3,408
5
35
63

then what is the solution? – johnniexo88 Aug 13 '16 at 05:11

score 0 · Answer 4 · edited May 23 '17 at 12:32

0

1) In your cellForRowAtIndexPath: method, assign button tag as index:

cell.yourbutton.tag = indexPath.row;

2) Add target and action for your button as below:

cell.yourbutton.addTarget(self, action: #selector(self.yourButtonClicked), forControlEvents: .TouchUpInside)

3) Code actions based on index as below in ViewControler:

func yourButtonClicked(sender: UIButton) {
    if sender.tag == 0 {
        // Your code here

    }
}

Ref SO: https://stackoverflow.com/a/20655223/4033273

edited May 23 '17 at 12:32

Community

1
1

answered Aug 13 '16 at 05:19

Moin Shirazi

4,372
2
26
38

what the difference betewwn my answer and your answer – Anbu.Karthik Aug 13 '16 at 05:24
`if sender.tag == 0` gives me this error: [UITapGestureRecognizer tag]: unrecognized selector sent to instance 0x7f……. *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UITapGestureRecognizer tag]: unrecognized selector sent to instance 0x7f…... – johnniexo88 Aug 13 '16 at 05:34

Get label from cell - swift

4 Answers4