SharedPreferences not working when trying to update TextView

Question

UPDATE: I have added the entire MainService AND MainActivity, in case there's something wrong elsewhere. Additionally, I have also added a solution provided below, although it still won't update the TextView.

I'm trying to change a TextView and I want it to be permanent, so I'm using SharedPreferences. Sadly, something is wrong, because the TextView doesn't update.

MainService:

public class MainService extends Service {

public static final String BROADCAST_ACTION = "com.example.vladpintea.friendsbeforecents.displayevent";
private final Handler handler = new Handler();
int counterr = 0;
Intent intentt;

String usedTimer;
long interval;

//TimerTask that will cause the run() runnable to happen.
TimerTask myTask = new TimerTask() {
    public void run() {
        stopSelf();
    }
};
//Timer that will make the runnable run.
Timer myTimer = new Timer();

@Override
public void onCreate() {
    intentt = new Intent(BROADCAST_ACTION);

    registerReceiver(counter, new IntentFilter(Intent.ACTION_SCREEN_ON));

    Toast.makeText(MainService.this, "Service, Created", Toast.LENGTH_SHORT).show();
}

private BroadcastReceiver counter = new BroadcastReceiver() {
    @Override
    public void onReceive(Context context, Intent intent) {
        Toast.makeText(MainService.this, "Whoops! You've Lost.", Toast.LENGTH_SHORT).show();
        Settings.System.putInt(getContentResolver(), Settings.System.SCREEN_OFF_TIMEOUT, 30000);
    }
};

@Override
public int onStartCommand(Intent intent, int flags, int startId) {
    Toast.makeText(MainService.this, "Service, Started", Toast.LENGTH_SHORT).show();

    usedTimer = intent.getStringExtra("timer");
    try {
        interval = Long.parseLong(usedTimer);
    } catch (NumberFormatException ignored) {}

    myTimer.schedule(myTask, interval);

    handler.removeCallbacks(sendUpdatesToUI);
    handler.postDelayed(sendUpdatesToUI, 1000);

    return super.onStartCommand(intent, flags, startId);
}

private Runnable sendUpdatesToUI = new Runnable() {
    public void run() {
        handler.postDelayed(this, 1000);
    }
};

public void DisplayLoggingInfoPlus() {
    intentt.putExtra("counter", String.valueOf(++counterr));
    sendBroadcast(intentt);
}

@Override
public void onDestroy() {
    DisplayLoggingInfoPlus();

    PowerManager pm = (PowerManager) getSystemService(Context.POWER_SERVICE);
    PowerManager.WakeLock wakeLock = pm.newWakeLock(PowerManager.FULL_WAKE_LOCK
            | PowerManager.ACQUIRE_CAUSES_WAKEUP
            | PowerManager.ON_AFTER_RELEASE, "MyWakeLock");
    wakeLock.acquire();

    Settings.System.putInt(getContentResolver(), Settings.System.SCREEN_OFF_TIMEOUT, 30000);
}

@Override
public IBinder onBind(Intent intent) {
    return null;
}

MainActivity:

public class MainActivity extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    final Button startApp = (Button) findViewById(R.id.startApp);
    final EditText timer = (EditText) findViewById(R.id.insertTimer);

    assert startApp != null;
    startApp.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            Toast.makeText(MainActivity.this, "Countdown, Started", Toast.LENGTH_SHORT).show();

            Intent intent = new Intent(MainActivity.this, MainService.class);

            assert timer != null;
            intent.putExtra("timer", timer.getText().toString());

            Settings.System.putInt(getContentResolver(), Settings.System.SCREEN_OFF_TIMEOUT, 1000);

            registerReceiver(broadcastReceiver, new IntentFilter(MainService.BROADCAST_ACTION));

            startService(intent);
        }
    });
}

private BroadcastReceiver broadcastReceiver = new BroadcastReceiver() {
    @Override
    public void onReceive(Context context, Intent intent) {
        updateUI(intent);
    }
};

private void updateUI(Intent intent) {
    String counter = intent.getStringExtra("counter");
    TextView txtCounter = (TextView) findViewById(R.id.txtCounter);
    assert txtCounter != null;

    SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(this);
    SharedPreferences.Editor editor = preferences.edit();
    editor.putString(counter,txtCounter.getText().toString());
    editor.commit();
}

}

Possible duplicate of [How to use SharedPreferences in Android to store, fetch and edit values](http://stackoverflow.com/questions/3624280/how-to-use-sharedpreferences-in-android-to-store-fetch-and-edit-values) — piotrek1543, Aug 15 '16 at 16:57
the asnswer is in link above. You save the value, but do not retrieve — piotrek1543, Aug 15 '16 at 16:58

gaara87 · Answer 1 · 2016-08-15T17:28:45.920

0

Change the following line

from

editor.putString(String.valueOf(txtCounter), counter);

to

editor.putString("counter",txtCounter.getText().toString());

edited Aug 15 '16 at 17:28

answered Aug 15 '16 at 16:58

gaara87

2,087
3
21
43

At txtCounter.getText() I get an error, saying it's a wrong argument type. – Vlad Pintea Aug 15 '16 at 17:28
added a toString() – gaara87 Aug 15 '16 at 17:29
Still no luck. There aren't any errors, it just won't update. – Vlad Pintea Aug 15 '16 at 18:37
can you be more specific? is the sharedpreference file not updated? – gaara87 Aug 15 '16 at 19:03

score 0 · Answer 2 · answered Aug 15 '16 at 17:03

To store values in shared preferences:

SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(this);
SharedPreferences.Editor editor = preferences.edit();
editor.putString("Counter",String.valueOf(txtCounter));
editor.apply();

To retrieve values from shared preferences:

SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(this);
String Counter= preferences.getString("Counter", "");
if(!Counter.equalsIgnoreCase(""))
{
    Counter= Counter+ "  Counter";  /* Edit the value here*/
}

score 0 · Accepted Answer · answered Aug 15 '16 at 19:08

Sadly, something is wrong, because the TextView doesn't update.

You need to update the TextView by calling setText():

String counter = intent.getStringExtra("counter");
TextView txtCounter = (TextView) findViewById(R.id.txtCounter);
txtCounter.setText(counter);

SharedPreferences not working when trying to update TextView

3 Answers3