Saving Files error

Question

need your eye on this.

void testSave()
    {
        fileName = curMonth.Text + curYear.Text + ".csv";
        if (!File.Exists(path+fileName))
        {
            File.Create(path + fileName);
        }
        else if (File.Exists(path + fileName))
        {
         try
           {
               lines = curDate.Text + "," + myDesc.Text + "," + myAmount.Text;
                File.AppendAllText(path + fileName, lines + Environment.NewLine);
                TextWriter tw = new StreamWriter(path + fileName, true);
                tw.Close();
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.Message);
            }
        }             
    }

The error come out as below:

The process cannot access the file 'C:\Users...\File.csv' because it is being used by another process.

Any suggestion or solution i could refer? thanks

You can remove all the lines of code, except for `File.AppendAllText`. You don't need to check for file existence and create file manually. `File.AppendAllText` creates file if it does not exist. You also do nothing with your `TextWriter` - it simply opens a file and closes it without writing to it. — Yeldar Kurmangaliyev, Aug 16 '16 at 08:55
I want to check for the file existence because if that is new file i wanna to add some header before the data go in, if there any ways to do so? — NewBieS, Aug 16 '16 at 09:07

Szabolcs Dombi · Accepted Answer · 2016-08-16T09:22:28.567

0

File.Create(path + fileName); is not closed so you cannot reopen.

remove the else keyword if you want.

void testSave()
{
    fileName = curMonth.Text + curYear.Text + ".csv";
    if (!File.Exists(path+fileName))
    {
        try
        {
            File.Create(path + fileName).Close();
        }
        catch (Exception ex)
        {
            MessageBox.Show(ex.Message);
        }
    }

    try
    {
       lines = curDate.Text + "," + myDesc.Text + "," + myAmount.Text;
        File.AppendAllText(path + fileName, lines + Environment.NewLine);
        TextWriter tw = new StreamWriter(path + fileName, true);
        tw.Close();
    }
    catch (Exception ex)
    {
        MessageBox.Show(ex.Message);
    }
}

edited Aug 16 '16 at 09:22

answered Aug 16 '16 at 08:52

Szabolcs Dombi

5,493
3
39
71

Still the same problems happening... – NewBieS Aug 16 '16 at 09:07
do you have all the folders created? – Szabolcs Dombi Aug 16 '16 at 09:10
ya, files will be create, but the data could not go in. – NewBieS Aug 16 '16 at 09:12
Hi, i found out the solution already. thanks ya. This way to solved. File.Create(path + fileName).Close(); – NewBieS Aug 16 '16 at 09:20
Yes, it is exactly like that, i marked as answer. thanks you – NewBieS Aug 17 '16 at 00:51

Saving Files error

1 Answers1