Radiogroup in recyclerview incorrect

Question

I am having a recyclerview where each list item has a radiogroup with 2 radio buttons. How can I store the state of each radiogroup correctly. Here is my code. On scrolling up/down the states are incorrects. Thanks

   public class ITOAdapter extends RecyclerView.Adapter<ITOAdapter.ViewHolder> {
    private Context context;
    private List<String> list;
    private List<Model> answers;
    private Client client;
    private String test;

    public ITOAdapter(Context context, List<String> list, Client client, String test) {
        this.context = context;
        this.list = list;
        this.client = client;
        this.answers = new ArrayList<>();
        this.test = test;
        for (int i=0; i<list.size(); i++) this.answers.add(new Model());
    }

    @Override
    public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        Context context = parent.getContext();
        LayoutInflater inflater = LayoutInflater.from(context);
        View contactView = null;
        if (viewType == Constants.VIEW_TYPE_CELL) {
            contactView = inflater.inflate(R.layout.item_ito, parent, false);
        }
        else {
            contactView = inflater.inflate(R.layout.item_ito_footer, parent, false);
        }
        return new ViewHolder(contactView);
    }

    @Override
    public int getItemViewType(int position) {
        return (position == list.size()-1) ? Constants.VIEW_TYPE_FOOTER : Constants.VIEW_TYPE_CELL;
    }


    private void setRadio(final ViewHolder holder, int selection) {

        System.out.println("SELECT:" + selection);
        RadioButton b1 = holder.rb0;
        RadioButton b2 = holder.rb1;

        b1.setChecked(false);
        b2.setChecked(false);

        if (selection == 0) b1.setChecked(true);
        if (selection == 1) b2.setChecked(true);
    }


    @Override
    public void onBindViewHolder(final ViewHolder vh, final int position) {
        vh.pos = position;
        vh.number.setText(vh.con + (position+1));
        vh.question.setText(list.get(position));

        setRadio(vh, answers.get(position).getState());

        vh.rb_group.setOnCheckedChangeListener(new RadioGroup.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(RadioGroup group, int checkedId) {
                if (checkedId != -1 ) {
                    RadioButton checkedRadioButton = (RadioButton) group.findViewById(checkedId);
                    vh.checkId = checkedId;
                    int checkedIndex = group.indexOfChild(checkedRadioButton);
                    answers.get(vh.pos).setState(checkedIndex);
                    setRadio(vh, answers.get(position).getState());
                }
            }
        });
    }

    @Override
    public int getItemCount() {
        return list.size();
    }

    public static class ViewHolder extends RecyclerView.ViewHolder {
        public TextView number;
        public TextViewPlus question;
        public RadioGroup rb_group;
        public Button btn;
        public String con;
        public int checkId;
        public RadioButton rb0, rb1;

        public int pos;

        public ViewHolder(View itemView) {
            super(itemView);
            number = (TextView) itemView.findViewById(R.id.number);
            question = (TextViewPlus) itemView.findViewById(R.id.question);
            rb0 = (RadioButton) itemView.findViewById(R.id.rb0);
            rb1 = (RadioButton) itemView.findViewById(R.id.rb1);
            rb_group = (RadioGroup) itemView.findViewById(R.id.rb_group);
            btn = (Button) itemView.findViewById(R.id.btn);
            con = number.getText().toString();
        }
    }

    private class Model{
        private int state;

        public Model(){
            this.state = -1;
        }

        public Model(int state){
            this.state = state;
        }

        public int getState() {
            return state;
        }

        public void setState(int state) {
            this.state = state;
        }
    }

}

the scope of radio button is to the list or to the list item? — Nouman Shah, Aug 16 '16 at 14:50
If I understand you correctly, there are keep position radiobutton in radiogroup. For example: we have 2 radiobutton, and we click to the first, then save 0 else 1 — Samuliak, Aug 16 '16 at 14:55

score 0 · Answer 1 · edited May 23 '17 at 12:00

0

Remove setRadio from onCheckedChanged. Also remove b1.setChecked(false); and b2.setChecked(false); from setRadio and let me know still you are getting problem Reference ListView with RadioGroup in each row

if (checkedId != -1 ) {
                    RadioButton checkedRadioButton = (RadioButton) group.findViewById(checkedId);
                    vh.checkId = checkedId;
switch(checkId)
{
case R.id.rb0:
answers.get(vh.pos).setState(0);
break;
case R.id.rb1:
answers.get(vh.pos).setState(1);
break;
}
}

edited May 23 '17 at 12:00

Community

1
1

answered Aug 16 '16 at 15:32

Ramit

416
3
8

I did, but still get problem ( – Samuliak Aug 16 '16 at 17:19
Please check int checkedIndex = group.indexOfChild(checkedRadioButton); giving correct value (0 or 1) assuming radio group having only 2 radio button as child not textview etc..The link I shared uses switch case to perform similar operation. You can give it a try I am updating answer for code. – Ramit Aug 16 '16 at 18:37

Radiogroup in recyclerview incorrect

1 Answers1

Linked