Format numbers in comma separated value

Question

I am using javascript to format the number with commas , it was working very fine.

But now the problem is if a value is comming in negative for example : -792004

It is returning the output like : -,792,004 that is comma is in the start.

How can I modify this method ?

Here is my code :

function Comma(number) {
    number = '' + number;
    if (number.length > 3) {
        var mod = number.length % 3;
        var output = (mod > 0 ? (number.substring(0, mod)) : '');
        for (i = 0; i < Math.floor(number.length / 3); i++) {
            if ((mod == 0) && (i == 0))
                output += number.substring(mod + 3 * i, mod + 3 * i + 3);
            else
                output += ',' + number.substring(mod + 3 * i, mod + 3 * i + 3);
        }
        return (output);
    } else return number;
}

Morteza Tourani · Accepted Answer · 2016-08-23T10:02:41.797

2

The simplest way I know which will helps you is toLocaleString() method on number:

var x = 10033001;
var y = -10033001;

console.log(x.toLocaleString(), y.toLocaleString());

But for correction of your code, you can remove number sign with Math.abs and add it after with Math.sign.

var sign = Math.sign(number);
number = Math.abs(number);
// Do the conversion
return (sign < 0) ? ("-" + output) : output;

edited Aug 23 '16 at 10:02

answered Aug 23 '16 at 09:51

Morteza Tourani

3,506
5
41
48

1

@AlinaAnjum You can use that *instead* of your method. – Michał Perłakowski Aug 23 '16 at 09:54
No i can't , because its a very old project and that method is called many more times – Alina Anjum Aug 23 '16 at 09:56
@AlinaAnjum `function Comma(number) { return number.toLocaleString(); }` – Morteza Tourani Aug 23 '16 at 09:59
I can not use any built in method because this project is very old and there is a browser issue – Alina Anjum Aug 23 '16 at 10:17
but it's pretty nice solution . Up vote for your answer – Alina Anjum Aug 23 '16 at 10:32
but in internet explorer its showing trailing .00 i.e. -353,291.00 how can i resolve this – Alina Anjum Aug 23 '16 at 10:33
@AlinaAnjum You can split result by `.` then return first part: `return output.split('.')[0]` – Morteza Tourani Aug 23 '16 at 14:04

score 1 · Answer 2 · answered Aug 23 '16 at 09:51

Try this:

const comma = function(number) {
  const prefix = number < 0 ? '-' : ''
  number = String(Math.abs(number))
  if (number.length > 3) {
    const mod = number.length % 3
    let output = (mod > 0 ? (number.substring(0,mod)) : '')
    for (let i = 0; i < Math.floor(number.length / 3); i++) {
      if (mod === 0 && i === 0)
        output += number.substring(mod+ 3 * i, mod + 3 * i + 3)
      else
        output+= ',' + number.substring(mod + 3 * i, mod + 3 * i + 3);
    }
    return prefix + output
  } else {
    return prefix + number
  }
}

If the number is negative, it assigns - to prefix. Then it changes number to its absolute value (Math.abs(number)). In the end it returns value with prefix.

I've tried the answer before the edit . and it worked fine for me . can you elaborate what did you changed now ? — Alina Anjum, Aug 23 '16 at 09:55

Format numbers in comma separated value

2 Answers2