Cursor not actually updating table

Question

I have the following setup in flask:

@app.route('/restart/<int:id>')
def feed_info(id):

   con = sqlite3.connect(database)
   con.row_factory = sqlite3.Row
   cur = con.cursor()

   main_q = "UPDATE feed SET update_flag = 1 WHERE id = {};".format(id)
   print(main_q)

   cur.execute(main_q)

   return "Set to update!"

However, even though the SQL seems to work on its own, it doesnt actually make the update when I call the method in Flask.

Any ideas?

You need to [commit](https://docs.python.org/2/library/sqlite3.html#sqlite3.Connection.commit) — FamousJameous, Aug 23 '16 at 16:01
You should also do: `cur.close()` and `con.close()`. Refer my answer for more details. — Moinuddin Quadri, Aug 23 '16 at 16:11

score 1 · Answer 1 · answered Aug 23 '16 at 16:02

1

That is because you need to commit. Add con.commit() after the cur.execute()

answered Aug 23 '16 at 16:02

applecrusher

5,508
5
39
89

Brilliant. Always something small. Thanks! – NickP Aug 23 '16 at 16:03

Moinuddin Quadri · Accepted Answer · 2016-08-23T16:10:19.807

1

You have to do con.commit() after cur.execute() else your changes will not be reflected in database.

Note: Also, you have to do cur.close() and con.close() after your logic to close the database connection. Because most of the Databases have the maximum connection limit, and if you will not close the connection explicitly, it will be alive until it reaches it connection-timeout value

edited Aug 23 '16 at 16:10

answered Aug 23 '16 at 16:03

Moinuddin Quadri

46,825
13
96
126

Cursor not actually updating table

2 Answers2