Retrofit not getting data from api

Question

I have some api that contains JSON with partner names.

I've set up interface and pojo model. I'll post below my code.

Here is my POJO model Partner:

public class Partner {   
    @SerializedName("name")
    @Expose
    private String name;   
    public String getName() {
        return name;
    }    
    public void setName(String name) {
        this.name = name;
    }
}

Now here is my interface:

public interface APIService {    
        @GET("Partner")
        Call<List<Partner>> getPartners();
}

And here is my APIHelper:

public class APIHelper {

    public static final String PARTNERS_URL = "https://part-of-url.herokuapp.com/partners.json/";

    public static APIService apiService;

    public static APIService getApiService() {
        if (apiService == null) {
            Retrofit retrofit = new Retrofit.Builder().baseUrl(PARTNERS_URL)
                    .addConverterFactory(GsonConverterFactory.create()).build();
            apiService = retrofit.create(APIService.class);
        }
        return apiService;
    }
}

And this is Fragment which contains Button where onClick method needs to get data from web.

public class DownloadMain extends Fragment implements Callback<Partner> {    
    private static final String TAG = DownloadMain.class.getSimpleName();    
    private Button dloadPartners;
    private Call callPartners;    
    public DownloadMain() {}    
    public DownloadMain newInstance() { return new DownloadMain(); }    

 @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {

        View view = inflater.inflate(R.layout.download_main, container, false);

        dloadPartners = (Button) view.findViewById(R.id.downloadPartners);
        dloadPartners.setOnClickListener(btnListener);    
        callPartners = APIHelper.getApiService().getPartners();    
        return view;
    }

    Button.OnClickListener btnListener = (new Button.OnClickListener() {
        @Override
        public void onClick(View v) {
            callPartners.clone().enqueue(DownloadMain.this);
        }
    });

    @Override
    public void onResponse(Call call, Response response) {    
        if(response.body() == null) {
            try {
                response.errorBody().string();
            } catch (IOException e) {
                e.printStackTrace();
            }
            Toast.makeText(getActivity(), "No Partners!", Toast.LENGTH_SHORT).show();
        } else {
            List<String> partners = (List<String>) response.body();
            Log.d(TAG, "Number of partners received: " + partners.size());
        Toast.makeText(getActivity(), "Partners downloaded!", Toast.LENGTH_SHORT).show();
        }    
    }

    @Override
    public void onFailure(Call call, Throwable t) {    
    }
}

This is all my code for getting Partners from web.

I'm getting this error on server side and can't resolve it:

No route matches [GET] "/partners.json/Partner"

QUESTION: Can someone look at this code and say what is wrong and why I'm not getting data from web and also how should I resolve this no route error?

Have you tried without the clone ? I am a bit septical about what it will do to the call. — Kevin LE GOFF, Aug 25 '16 at 14:49
Yes I've tried, clone just allows me to click on button multiple times but still gives me message No Partners! but without clone I can only click once. — RubyDigger19, Aug 25 '16 at 14:56
What is the json format your server is returning ? I am thinking you might need to add a POJO like PartnersResponse that contains and deserialize the list of partners. — Kevin LE GOFF, Aug 25 '16 at 15:03
It's array of strings like this `[ "partner1", "partner2", ..., "partner200" ]` — RubyDigger19, Aug 25 '16 at 15:06
Then your service definition should be @GET("Partner") Call> getPartners(); — Kevin LE GOFF, Aug 25 '16 at 15:18
@KevinLEGOFF did it like you said but still getting message "No Partners!".. can't figure what is wrong. — RubyDigger19, Aug 26 '16 at 11:33
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/121957/discussion-between-kevin-le-goff-and-unknown19). — Kevin LE GOFF, Aug 26 '16 at 17:28
add a `HttpLoggingInterceptor` to see what the error is. look at the answer to this question to see how to implement it http://stackoverflow.com/questions/32514410/logging-with-retrofit-2 — ono, Aug 26 '16 at 18:20
The error is `No route matches [GET] "/partners.json/Partner"` — RubyDigger19, Aug 26 '16 at 18:26
Then the problem comes from the way youn contact the server. Is partners.json a file ? — Kevin LE GOFF, Aug 27 '16 at 12:03
@KevinLEGOFF It is not a file. It's created form database (rails app) and then with json builder created an json.array where partners names are passing — RubyDigger19, Aug 27 '16 at 12:25
Have you tested the endpoint with the url used by retrofit ?? — Kevin LE GOFF, Aug 28 '16 at 08:33
No I didn't, how should I test this? (I'm pretty new to android) — RubyDigger19, Aug 28 '16 at 08:44
When I try your URL in postman I get an no such app webpage. is this the right url? https://part-of-url.herokuapp.com/partners.json/Partner — Danny Beaumont, Aug 28 '16 at 09:03
@DannyBeaumont This is right url [link](https://ams-biomasa.herokuapp.com/partners.json/) I've checked it in Postman and it is good — RubyDigger19, Aug 28 '16 at 09:22
@Unknown19 That works so remove the partners 'partners.json' from the base url and it to the @GET("partners.json") annotation I think that should fix it. — Danny Beaumont, Aug 28 '16 at 15:52

Danny Beaumont · Accepted Answer · 2016-08-29T07:29:46.830

1

change your get path like so

public interface APIService {    
    @GET("partners.json")
    Call<List<Partner>> getPartners();
}

and remove that path from your base url.

public class APIHelper {

public static final String PARTNERS_URL = "https://part-of-url.herokuapp.com/";

public static APIService apiService;

public static APIService getApiService() {
    if (apiService == null) {
        Retrofit retrofit = new Retrofit.Builder().baseUrl(PARTNERS_URL)
                .addConverterFactory(GsonConverterFactory.create()).build();
        apiService = retrofit.create(APIService.class);
    }
    return apiService;
}
}

edited Aug 29 '16 at 07:29

answered Aug 28 '16 at 16:23

Danny Beaumont

356
1
8

Done, no errors but also not getting any toast notification I've put in on response method. How should I check if data is downloaded? – RubyDigger19 Aug 29 '16 at 14:03
put a break point on if(response.body() == null) then add response.body() to watches and see what you're getting. – Danny Beaumont Aug 29 '16 at 15:18
Did like you said but I'm not getting anything... It say that it is connected and nothing happens – RubyDigger19 Aug 29 '16 at 19:05
I'm not your pojo is being converted I tried you're response in a pojo generator and got errors I'm retrofit is having a issue reading the response. – Danny Beaumont Aug 29 '16 at 20:28
So I need to somehow fix pojo – RubyDigger19 Aug 29 '16 at 20:36
So do you have an idea how should pojo look? – RubyDigger19 Aug 30 '16 at 05:56

Retrofit not getting data from api

1 Answers1