How to exit in the middle of a function?

Question

How about nested if?

$scope.addToCart = function () {
    if (flagA) {
        if (flagB) {
            if (flagC) {
                alert('nononono!');
                return;
            }
        }
    }
    someAnotherFunction();
};

I have a function:

$scope.addToCart = function () {
    var foo = 5;
    if (someFlag == 'Y') {
        alert('warning!');
        return;
    }
    someAnotherFunction();
};

I invoke this function somewhere

ng-click = "addToCart()"

My intention is to exit this function if

someFlag == 'Y'

then not to execute

someAnotherFunction();

But it still execute it.

WebStorm tell me this return is unnecessary so it could be safely removed.

`if (someFlag == 'Y') {` condition must be failing. Are you getting alert? — Tushar, Aug 25 '16 at 15:07
Unexpected behaviour is usually what happens when code relies on global variables. — Mladen Ilić, Aug 25 '16 at 15:10
@untmat [this](http://stackoverflow.com/questions/10459207/how-can-i-exit-from-a-javascript-function?noredirect=1&lq=1) answer says break could exit a loop not a function. — ding van, Aug 25 '16 at 15:14
The current answers recommend to use an `else` block. While that will likely solve your problem, it's impossible that anything after the `return` statement is executed in the first place. You should figure out what the actual issue with your code is, not work around it. — Felix Kling, Aug 25 '16 at 15:19
Could you post more code? Specifically where `someFlag` is set? — Seth, Aug 25 '16 at 15:19
It is more likely that the `$scope.addToCart()` function is being called again (after `someFlag` has changed), or that `someAnotherFunction()` is being called from somewhere else, than it is that the `return` statement is not being executed immediately after the `alert()`. — Makyen, Aug 25 '16 at 15:23
In response to nested ifs: if you just want to check conditions and do nothing else in the if blocks, `if (flagA && flagB && flagC) {...}`. The workaround proposed in the answers has the limitations, look here: http://stackoverflow.com/questions/1820839/using-return-instead-of-else-in-javascript — AgataB, Aug 25 '16 at 15:37

score 2 · Accepted Answer · edited May 23 '17 at 10:29

2

If you are sure that the if condition is satisfied, but return isn't working, then you can also try putting someAnotherFunction(); into else:

if (someFlag == 'Y') {
    alert('warning!');
    return;
}
else {
    someAnotherFunction();
}

That way someAnotherFunction() can be executed only if the if block isn't.

Addendum

The original code should work and this is just a workaround, as pointed out in the comment. However both methods achieve the same goal in theory.

For more details, check this question - for details on the differences.

edited May 23 '17 at 10:29

Community

1
1

answered Aug 25 '16 at 15:13

AgataB

647
2
10
18

1

`if` is not a loop. And while this is a good workaround, the original code should work just fine. – Felix Kling Aug 25 '16 at 15:17
I meant block, not loop, cheers. – AgataB Aug 25 '16 at 15:20

score 0 · Answer 2 · answered Aug 25 '16 at 15:12

You could put the call to the other function in the else-block:

$scope.addToCart = function () {
    var foo = 5;
    if (someFlag == 'Y') {
        alert('warning!');
        return;
    } else {
      someAnotherFunction();
    }

};

That should take you closer to understanding what is going on

How to exit in the middle of a function?

2 Answers2