When Firebase function ends in Swift

Question

I am using a Firebase in my app, it queries through a lot of users and gets the specific data that is needed, but when it starts querying - the rest of the function keep running too, instead of just querying so I can't understand when it ends.

For example in this code:

ref.observeEventType(.ChildAdded, withBlock: { snapshot in

            let user = snapshot.value!.objectForKey("User")
            let name = (user!["Name"])! as! String

            print("name")

            })
print("done")

Let's say we have 3 users in the Firebase Database - the printed code will be:

done
nameuser1
nameuser2
nameuser3

(or the done will be somewhere between the nameusers, depends on your internet connection - BUT it won't be the the last)

@WeiJay But is there anything I can do to run another code when the Firebase Function ends? — Eliko, Aug 29 '16 at 08:46
what are you going to do after a child is added? Or you want to do something after all children are added? — Willjay, Aug 29 '16 at 08:53
@WeiJay I want to do something after **all** childen are added (aka when function has ended) — Eliko, Aug 29 '16 at 08:55
Value events are triggered after childAdded events, so you can use that if you need to do something after all children have been added. More insight and examples: http://stackoverflow.com/questions/33516346/ — eLwoodianer, Nov 08 '16 at 15:11

score 1 · Answer 1 · answered Aug 29 '16 at 08:37

1

The Firebase callback block is asynchronous, while the print line is synchronous. This means that the block will run whenever it receives data back from its underlaying API calls, while the "print" (and other) lines which are outside the block will continue to be run seqeuentially.

This is why the print line is run before the callback block has been run.

answered Aug 29 '16 at 08:37

tskulbru

2,336
1
20
38

You are 100% right, but is there anything I can do to run another code when the Firebase Function ends? – Eliko Aug 29 '16 at 08:43

score 1 · Answer 2 · answered Nov 20 '16 at 21:27

You can use dispatch group, but only if you must, and you shouldn't do it on your main thread.

It's looks like this:

 let group = dispatch_group_create()
 dispatch_group_enter(group)

ref.observeEventType(.ChildAdded, withBlock: { snapshot in

            let user = snapshot.value!.objectForKey("User")
            let name = (user!["Name"])! as! String

            print("name")
            dispatch_group_leave(group)

            })

    dispatch_group_wait(group, DISPATCH_TIME_FOREVER)
//will reach here only after group_leave  is called
print("done")

MikeG · Answer 3 · 2017-04-16T00:57:52.807

The "problem" your experiencing is due to the function observeEventType() being asynchronous. So it returns control to its caller before the values have actually been retrieved. Use an asynchronous callback like this and pass a function that will be called each time a value is retrieved from firebase...

updated for Swift 3

func getDataFromFirebase(callback: @escaping (_ user: String, _ name: String)->Void){
   ref.observeEvent(of: .childAdded, with:{(snapshot)-> Void in

        let user = snapshot.value!.objectForKey("User") as! String
        let name = (user!["Name"])! as! String

        callback(user, name)

   })
}

and call the function like this...

getDataFromFirebase(callback: {(user, name)-> Void in 
    print("got a user: \(user) and a name: \(name)")
})

This will print a user and a name for every child that is retrieved

score 0 · Answer 4 · edited Jun 20 '20 at 09:12

let's start by analyzing your code :

firebase observe function is asynchronous
the print function is synchronous,

result: it's impossible to force an asyc func to work as a sync.

It's just a wrong approach

Concerning how the compiler will compile your code :

first of all he will fire the observeEventType function and than he will pass to execute the other stuff (simply because it's async and needs time to finish the execution).

My advice for you to get this work the way you want is to prepare the whole of your needed data in viewDidLoad() function (put them in variables) and than just use these variables in your private functions.

When Firebase function ends in Swift

4 Answers4

Linked