How to define and set TextView in a for loop to concise the code?

Question

I want to make the below code concise. It has repetition of similar kind of calls. I tried LinearView and GetChildCount method but It does not give me proper results, I might have misunderstood how to define these in loop using Childs Or other method.

Can any one help ?

tv1 = (EditText) findViewById(R.id.tv1);
tv2 = (EditText) findViewById(R.id.tv2);
tv3 = (EditText) findViewById(R.id.tv3);
// ...
// ... and so on till
// ...
tv25 = (EditText) findViewById(R.id.tv25);

// Similarly
tv1.setText(stall);
// ... till ...
tv25.setText(stall);

Please don't forget to tag your language! You're very unlikely to get any responses otherwise... — Praveen, Sep 02 '16 at 01:05
you should take a look into Data Binding Library [link](https://developer.android.com/topic/libraries/data-binding/index.html) — Bob, Sep 06 '16 at 17:01

František Hlinka · Accepted Answer · 2016-09-06T16:55:30.683

Use this:

    //create an array of ids
    int[] editextIDs = {R.id.tv1
            ,R.id.tv2
            ,R.id.tv3
            ,R.id.tv4
            ,R.id.tv5
            ,R.id.tv6
            ,R.id.tv7
            ,R.id.tv8
            ,R.id.tv9
            ,R.id.tv10
            ,R.id.tv11
            ,R.id.tv12
            ,R.id.tv13
            ,R.id.tv14
            ,R.id.tv15
            ,R.id.tv16
            ,R.id.tv17
            ,R.id.tv18
            ,R.id.tv19
            ,R.id.tv20
            ,R.id.tv21
            ,R.id.tv22
            ,R.id.tv23
            ,R.id.tv24
            ,R.id.tv25
    };
    //create an arraylist of 25 editTexts
    ArrayList<EditText> editTexts = new ArrayList<>();
    //fill the array
    for(int i = 0; i < 25 ;i++)
    {
        editTexts.add(i,(EditText) findViewById(editextIDs[i]));
    }
    //set the texts
    for(int i = 25; i <25 ;i++)
    {
        editTexts.get(i).setText(stall);
    }

This may seem a lot of cut and pasting, but i created the ,R.id.tvX with excel. To do this, you write

,R.id.tv1

and then drag it till you got 25 fields.

Also, if you want to clean your code a bit, you may create a class in which you paste the array creation part and make the variable static. For example if you call the class EditTextArrayHandler, you would get the array like this:

int[] editextIDs = EditTextArrayHandler.editTextIDs;

Hope it helps.

You may want to look at the post linked in the comments. This is just about the same code needed as the original question — OneCricketeer, Sep 06 '16 at 17:06

Vyacheslav · Answer 2 · 2016-09-06T17:12:30.003

0

Using Java reflections can dramatically decrease your code

EditText[] tv_ar = new EditText[25];
for (int i = 0; i < et_ar.length; i++) {
    int cur_tv_index = R.id.class.getField("tv" + Integer.toString(i+1)).getInt(null);
    tv_ar[i] = (EditText) findViewById(cur_tv_index);
}

It is possible to use

int cur_tv_index=context.getResources().getIdentifier("tv" + Integer.toString(i+1), "id", context.getPackageName());

edited Sep 06 '16 at 17:12

answered Sep 06 '16 at 17:04

Vyacheslav

26,359
19
112
194

What's wrong with `Resources.getIdentifier()`? – OneCricketeer Sep 06 '16 at 17:06
Nothing. I just have not tested it. I think, at least, there is a `Context` depend. It makes no sense in common Android programming. – Vyacheslav Sep 06 '16 at 17:11
Makes no sense? An Activity is a Context. There is also `getApplicationContext()`, so I don't understand that comment – OneCricketeer Sep 06 '16 at 17:13
'It makes no sense' - I meant namely you wrote: ' An Activity is a Context. There is also `getApplicationContext()`, so I don't understand that comment'. You are totally right. – Vyacheslav Sep 06 '16 at 17:25
I'm just making the point that using a Context is very common in most applications that I have seen. – OneCricketeer Sep 06 '16 at 17:26

How to define and set TextView in a for loop to concise the code?

2 Answers2