BufferedWriter doesnt write JSON String correctly

Question

I wrote a code that gets a JSON text from a website and formats it so it is easier to read. My problem with the code is:

public static void gsonFile(){
  try {
    re = new BufferedReader(new FileReader(dateiname));
    Gson gson = new GsonBuilder().setPrettyPrinting().create();
    JsonParser jp = new JsonParser();
    String uglyJSONString ="";
    uglyJSONString = re.readLine();
    JsonElement je = jp.parse(uglyJSONString);  
    String prettyJsonString = gson.toJson(je);
    System.out.println(prettyJsonString);

    wr = new BufferedWriter(new FileWriter(dateiname));
    wr.write(prettyJsonString);

    wr.close();
    re.close();

} catch (IOException e) {
    // TODO Auto-generated catch block
    e.printStackTrace();
}
}

It correctly prints it into the console : http://imgur.com/B8MTlYW.png

But in my txt file it looks like this: http://imgur.com/N8iN7dv.png

What can I do so it correctly prints it into the file? (separated by new lines)

My bad: Those aren't images and shouldn't be posted as such. They should be posted as code-formatted text. Please go through the [help] to learn more about this. — Hovercraft Full Of Eels, Sep 05 '16 at 15:07

Raphaël · Accepted Answer · 2016-09-05T15:17:02.443

2

Gson uses \n as line delimiter (as can be seen in the newline method here).

Since Notepad does not understand \n you can either open your result file with another file editor (Wordpad, Notepad++, Atom, Sublime Text, etc.) or replace the \n by \r\n before writing it:

prettyJsonString = prettyJsonString.replace("\n", "\r\n");

edited Sep 05 '16 at 15:17

answered Sep 05 '16 at 15:06

Raphaël

3,646
27
28

score 2 · Answer 2 · answered Sep 05 '16 at 15:14

FileReader and FileWriter are old utility classes that use the platform encoding. This gives non-portable files. And for JSON one ordinarily uses UTF-8.

Path datei = Paths.get(dateiname);
re = Files.newBufferedReader(datei, StandardCharsets.UTF_8);

Or

List<String> lines = Files.readAllLines(datei, StandardCharsets.UTF_8);
// Without line endings as usual.

Or

String text = new String(Files.readAllBytes(datei), StandardCharsets.UTF_8);

And later:

Files.write(text.getBytes(StandardCharsets.UTF_8));

score 1 · Answer 3 · answered Sep 05 '16 at 15:05

1

It is problem with your text editor. Not with text. It incorrectly process new line character.

I suppose it expect CR LF(Windows way) symbols and Gson generate only LF symbol (Unix way).

answered Sep 05 '16 at 15:05

talex

17,973
3
29
66

Try opening it with another editor (I know that you can see the whitespace characters with notepad++ for instance) and check the layout and whitespace there. – Timo Sep 05 '16 at 15:06

score 1 · Answer 4 · edited May 23 '17 at 11:51

1

After a quick search this topic might come handy.

Strings written to file do not preserve line breaks

Also, opening in another editor like the others said will help too

edited May 23 '17 at 11:51

Community

1
1

answered Sep 05 '16 at 15:10

Juan Martin Lichowski

341
2
5

BufferedWriter doesnt write JSON String correctly

4 Answers4