Java ExecutorService - What if awaitTermination() fails?

Question

If I have the following code, which works fine:

ExecutorService service = Executors.newFixedThreadPool(100);

[....]

List<Future<SomeObject>> futures = service.invokeAll(callables);
for (Future f : futures) {
    f.get();
}

// shutdown the service after all Callables are finished.
service.shutdown();

boolean serviceIsShutDown = service.awaitTermination(5, TimeUnit.SECONDS);
if (serviceIsShutDown) {
    System.out.println("Service terminated normally. All ok.");
} else  {
    // What if it's not shutDown?
    [...]
    // this? 
    //service = null;
}

Question: What if the call

boolean serviceIsShutDown = service.awaitTermination(5, TimeUnit.SECONDS);

returns false because the timeout hits?

I guess the Threads in the ExecutorService will remain in state WAIT. What is the best solution to continue? Setting the service to null and having the GarbageCollector remove it? But what happens with the related Threads? Will it ever be garbage collected as there are still references?

The code usually works, but just be curious. What to do if it returns false?

depends on what you want to do. You can try to force a graceful shutdown with .shutdown() or a hard shutdown with shutdownNow() — jordaniac89, Sep 09 '16 at 14:46
Hi Joschi, you have change your shutdown logic as per this post: http://stackoverflow.com/questions/4958330/java-executorservice-awaittermination-of-all-recursively-created-tasks/39295555#39295555 — Ravindra babu, Sep 09 '16 at 15:25

score 2 · Answer 1 · answered Sep 09 '16 at 14:54

2

If you want to "force" the termination of your ExecutorService just use:

shutdownNow()

look here for description:

answered Sep 09 '16 at 14:54

Moshe Arad

3,587
4
18
33

Thank you for the answer! I'll give it a try – Joschi Sep 10 '16 at 05:35

Andrew Lygin · Accepted Answer · 2016-09-09T15:57:53.757

If awaitTermination() returns false in your example, you have an option to try calling shutdownNow(). This method will do its best to cancel all the tasks that are still being executed, but it guarantees nothing. Some poorly implemented tasks might have no cancellation policy and just run forever. In this case, the threads will never be terminated and the executor will never be garbage collected.

Such tasks will also prevent your program from graceful termination (if you don't mark your working threads as daemons).

For instance, if your task only contains an empty infinite loop, it won't be cancelled even if you call shutdownNow().

There also might be the case that a task has no proper cancellation policy, and runs too long (but not forever). For instance, it has a very-very long empty loop. You might fail to shutdown a pool that is being executed such task by means of shutdown()/shutdownNow(), but sooner or later it will finish its work and the thread will be terminated along with the executor.

Thank you for the answer and the detailed explanation! – Joschi Sep 10 '16 at 05:36 — Joschi, Sep 10 '16 at 05:36

Java ExecutorService - What if awaitTermination() fails?

2 Answers2