frame incorrectly updates when changing an element

Question

I want to change some of my JFrame components(JPanel, ChartPanel) after some action event occured(button clicked). Below a concrete example:

Initially I'm starting my frame empty(only with menu bar and without any other panels). I'm clicking menu 'file > open', choose a file and here become a chart. After that for clarity I've resized my frame. All is perfect. But next I'm clicking choose file again to get new chart and instead of this my chart not properly updated: here is an illustration of problem

And here is my code:

public MenuBarDataAnalyser() {

    JMenu menuFile = new JMenu("File");

    itmOpen = new JMenuItem("Open...");
    itmOpen.addActionListener(this);

    add(menuFile);
    menuFile.add(itmOpen);
}


@Override
public void actionPerformed(ActionEvent e) {
if(source == itmOpen){
        final JFileChooser fch = new JFileChooser();
        FileFilter filter = new FileNameExtensionFilter("FITS file", "fits");
        fch.setFileFilter(filter);
        int response = fch.showOpenDialog(itmOpen);
        if (response == JFileChooser.APPROVE_OPTION){
            String pathFilename = fch.getSelectedFile().toString();
            JFreeChart chart = GUIDataAnalyserFrame.createChart(pathFilename);
                ChartPanel chartPanel = new ChartPanel(chart, true, true, true, false, true);
                JButton button = new JButton("Calibrate");
                JPanel buttonPanel = new JPanel();
                buttonPanel.add(button);

                chartPanel.revalidate();

                GUIDataAnalyserApp.analyserFrame.add(chartPanel, BorderLayout.CENTER);
                GUIDataAnalyserApp.analyserFrame.add(buttonPanel, BorderLayout.EAST);
                GUIDataAnalyserApp.analyserFrame.revalidate();
                }
         }
}

Why this happening and what I need to change?

score 3 · Accepted Answer · edited May 23 '17 at 12:06

3

A guess since you've not posted a valid minimal code example program, but you should remove the old components from the container, then add the new ones, then call revalidate() THEN call repaint() -- a critical step which you appear to be missing. The repaint should help clean out old "dirty" pixels.

Or you could go the much easier route and simply use a CardLayout to help you swap views.

edited May 23 '17 at 12:06

Community

1
1

answered Sep 27 '16 at 00:32

Hovercraft Full Of Eels

283,665
25
256
373

Thank you! It works. I removed my elements from frame(if they are exists), then called revalidate and repaint for each element. – Andrei Sh Sep 27 '16 at 00:56
@AndreiSh: no, not for each element. Call it on the container, here `GUIDataAnalyserApp.analyserFrame`, after removing and adding all. – Hovercraft Full Of Eels Sep 27 '16 at 01:45
1

Similar alternatives are suggested [here](http://stackoverflow.com/a/39120572/230513). – trashgod Sep 27 '16 at 02:09

frame incorrectly updates when changing an element

1 Answers1