Create zip archive with multiple files

Question

I'm using following code where I pass .pdf file names with their paths to create zip file.

for f in lstFileNames:
        with zipfile.ZipFile('reportDir' + str(uuid.uuid4()) + '.zip', 'w') as myzip:
            myzip.write(f)

It only archives one file though. I need to archive all files in my list in one single zip folder.

Before people start to point out, yes I have consulted answers from this and this link but the code given there doesn't work for me. The code runs but I can't find generated zip file anywhere in my computer.

A simple straightforward answer would be appreciated. Thanks.

Sardorbek Imomaliev · Accepted Answer · 2018-06-19T04:52:27.843

45

Order is incorrect. You are creating new zipfile object for each item in lstFileNames

Should be like this.

with zipfile.ZipFile('reportDir' + str(uuid.uuid4()) + '.zip', 'w') as myzip:
    for f in lstFileNames:   
        myzip.write(f)

edited Jun 19 '18 at 04:52

answered Sep 29 '16 at 10:35

Sardorbek Imomaliev

14,861
2
51
63

well, damn. It was as simple as that. Thanks a bunch! – Tahreem Iqbal Sep 29 '16 at 10:39
1

Isn't `myzip.close()` redundant inside context manager? It should be closed automagically after exited "with" statement section. – Hunter_71 Jun 18 '18 at 13:21
1

@Hunter_71 yes, it was recently added by someone else – Sardorbek Imomaliev Jun 19 '18 at 04:52
Nice this answer came in handy for me, thanks @SardorbekImomaliev – Helen Neely Aug 10 '18 at 08:42
1

@SardorbekImomaliev I have used this suggestion, but for reason it is creating a zipfile with folders/folder/folder/files. Is there anyway to simply create a zip with files? – Helen Neely Aug 14 '18 at 19:41
@HelenNeely I suggest you create separate question for this and paste your code, it is probably related on how you generate list of filenames for archive – Sardorbek Imomaliev Aug 15 '18 at 15:41
Thanks, I got it working with help from sample code solution to someone else's question :) – Helen Neely Aug 15 '18 at 17:15

Create zip archive with multiple files

1 Answers1

Linked