php - db insert error - query was empty

Question

i'm trying to insert some records into the db and i'm getting this error: Query was empty

$data= json_decode(file_get_contents("php://input"));
$usercomment= mysql_real_escape_string($data->usercomment);
$wardrobe= mysql_real_escape_string($data->wardrobe);
$ctype= mysql_real_escape_string($data->ctype);
$pic= mysql_real_escape_string($data->pic);
$vtype= mysql_real_escape_string($data->vtype);

$query=mysql_query ("INSERT INTO db.comment(`comment`,`pic`,`wardrobe`,`comment_type`,`vtype`)
VALUES('".$usercomment."','".$pic."','".$wardrobe."','".$ctype."','".$vtype."')");
$Result1 = mysql_query($query, $dbcon) or die(mysql_error());

You're adding a mysql_query inside a mysql_query – Phiter Sep 29 '16 at 11:27 — Phiter, Sep 29 '16 at 11:27

score 1 · Accepted Answer · edited May 23 '17 at 12:15

$query is already a mysql_query, so you can't add it inside the other mysql_query.

You can make $query be the string for the mysql_query below it.

$query = "INSERT INTO db.comment(`comment`,`pic`,`wardrobe`,`comment_type`,`vtype`)    VALUES('".$usercomment."','".$pic."','".$wardrobe."','".$ctype."','".$vtype."')";

$result1 = mysql_query($query, $dbcon) or die(mysql_error());

Also, don't use the mysql_* functions, use mysqli_* instead.

See this answer for more details on why.

score 0 · Answer 2 · answered Sep 29 '16 at 11:41

I have modified your code.. try this

data= json_decode(file_get_contents("php://input"));
$usercomment= mysql_real_escape_string($data->usercomment);
$wardrobe= mysql_real_escape_string($data->wardrobe);
$ctype= mysql_real_escape_string($data->ctype);
$pic= mysql_real_escape_string($data->pic);
$vtype= mysql_real_escape_string($data->vtype);

$query="INSERT INTO db.comment(`comment`,`pic`,`wardrobe`,`comment_type`,`vtype`)
VALUES('".$usercomment."','".$pic."','".$wardrobe."','".$ctype."','".$vtype."')";
$Result1 = mysql_query($query) or die(mysql_error());

php - db insert error - query was empty

2 Answers2