PHP MySql update query not working,says:- Undefined Index

Question

I have follow the tutorial of it where i want to update my database using two php files.

<?php
while($row = mysqli_fetch_array($records))
{
    echo "<tr><form action =update.php method=post>";
    echo "<td><input type=text name=Cname value='".$row['CustomerName']."'></td>";
    echo "<td><input type=number name=size min=1 value='".$row['TableSize']."'></td>";
    echo "<td><input type=date name=Adate value='".$row['DateA']."'></td>";
    echo "<td><input type=time name=Atime value='".$row['TimeA']."'></td>";
    echo "<td><input type=tel name=phonenumber value='".$row['PhoneNumber']."'></td>";
    echo "<input type=hidden name=id value='".$row['TableID']."'>";
    echo "<td><input type=submit>";
    echo"</form></tr>";
}
?>

this is what i use for the first php file as for the update.php:

<?php

$con = mysqli_connect('127.0.0.1','root','');

mysqli_select_db($con,'restaurant');

$sql = "UPDATE addtable SET CustomerName='$_POST[Cname]', TableSize='$_POST[size]', DateA='$_POST[Adate]',TimeA='$_POST[Atime]',PhoneNumber='$_POST[phonenumber]', WHERE TableID=$_POST[id]";

if(mysqli_query($con,$sql))
    header("refresh:1; url=AssignBooking.php");
else
    echo "Not Update";

?>

but the $sql line just doesn't work as it says that

Undefined index: Cname and other indexes too.

your code is vulnarable to SQL Injection. check for `prepared statement` to prevent from `SQL Injection` — Alive to die - Anant, Oct 06 '16 at 04:47
check the code of the link:- https://eval.in/655964 (only code not output),use it and check.Meanwhile your original form code is correct,leave as it is. — Alive to die - Anant, Oct 06 '16 at 05:20

rahul · Answer 1 · 2016-10-06T07:35:36.877

1

put quotes outside the post variable:

$sql = "UPDATE addtable SET CustomerName='".$_POST['Cname']."', TableSize='".$_POST['size']."', DateA='".$_POST['Adate']."',TimeA='".$_POST['Atime']."',PhoneNumber='".$_POST['phonenumber']."', WHERE TableID=".$_POST['id'];

edited Oct 06 '16 at 07:35

answered Oct 06 '16 at 04:38

rahul

841
1
8
18

That wont work. your missing quotes. – Xatenev Oct 06 '16 at 07:32
@Xatenev long time going back to core php mysql query statements. now its ok.. – rahul Oct 06 '16 at 07:36
no worries. good job – Xatenev Oct 06 '16 at 07:55

score 0 · Answer 2 · edited Oct 06 '16 at 07:12

0

According to your code put the name attributes value ' single quote.

<?php
while($row = mysqli_fetch_array($records))
{
    echo "<tr><form action =update.php method=post>";
    echo "<td><input type=text name='Cname' value='".$row['CustomerName']."'></td>";
    echo "<td><input type=number name='size' min=1 value='".$row['TableSize']."'></td>";
    echo "<td><input type=date name='Adate' value='".$row['DateA']."'></td>";
    echo "<td><input type=time name='Atime' value='".$row['TimeA']."'></td>";
    echo "<td><input type=tel name='phonenumber' value='".$row['PhoneNumber']."'></td>";
    echo "<input type=hidden name="id" value='".$row['TableID']."'>";
    echo "<td><input type=submit>";
    echo"</form></tr>";
}
?>

Put quotes accordingly

UPDATE addtable SET CustomerName='".$_POST['Cname']."',TableSize='".$_POST['size']."',    DateA='".$_POST['Adate']."',TimeA='".$_POST['Atime']."',PhoneNumber='".$_POST['phonenumber']."' WHERE TableID=$_POST['id'];

edited Oct 06 '16 at 07:12

Vipin Sahu

3
3

answered Oct 06 '16 at 04:36

Gulmuhammad Akbari

1,986
2
13
28

I edited my answer – Gulmuhammad Akbari Oct 06 '16 at 04:42
i tried before the attributes value with " but it will have an error saying that it expected a semicolon – DarrenE Oct 06 '16 at 04:50
Do not use like this `value='".$row['CustomerName']."'` instead of that `value=".$row['CustomerName']."` – Gulmuhammad Akbari Oct 06 '16 at 04:53
i mean when i put "Cname", it will expect a semicolon after the " which wouldn't make the code works – DarrenE Oct 06 '16 at 04:56
Ok, change it to `'` like this: `name='Cname'` – Gulmuhammad Akbari Oct 06 '16 at 04:57
What is the error again? – Gulmuhammad Akbari Oct 06 '16 at 05:05
I have tried your way and it still doesn't work but i have set the name='Cname' and as for the update.php i couldn't put "" in between Cname as it will become an undefined constant. – DarrenE Oct 06 '16 at 05:07
Replace with this: `UPDATE addtable SET CustomerName=$_POST['Cname'], TableSize=$_POST['size'], DateA=$_POST['Adate'],TimeA=$_POST['Atime'],PhoneNumber=$_POST['phonenumber'], WHERE TableID=$_POST['id']` – Gulmuhammad Akbari Oct 06 '16 at 05:08
its the same whether if i put " or ' in between Cname and the others – DarrenE Oct 06 '16 at 05:09
@DarrenE check the code of the link:- https://eval.in/655964 (only code not output),use it and check.Meanwhile your original form code is correct,leave as it is – Alive to die - Anant Oct 06 '16 at 05:09

PHP MySql update query not working,says:- Undefined Index

2 Answers2