HTML Button if script not working

Question

I am trying to make a script that will run a different function every time the button is clicked in a ordered way. So for example when the button is clicked it will run the tick1 function first, then when pressed again it will run the tick2 function. This is my attempt but it will only run the tick1 function. Many thanks, Simon

<script>
var trafficktick = 1;
function tick() {
    if (trafficktick = 1) {
        tick1()
        var traffictick =  trafficktick + 1;
    } else if (trafficktick = 2) {
        tick2()
        var traffictick = trafficktick + 1;
    } else {
        var trafficktick = 1;
    }
} 
</script>

youre also rewriting traffictick continually plus you should use `===` for compare. — Craicerjack, Oct 07 '16 at 13:30
Above comments are correct and will solve the issue. As a sidenote, using an array or similar will make coding this way more extensible, sicne you won't have to write an if clause for every function you add. — Shilly, Oct 07 '16 at 13:32
Why are people posting answers if there already are identical ones previously posted? — Chris, Oct 07 '16 at 13:33
Using == instead of === is perfectly acceptable, by the way. — Feathercrown, Oct 07 '16 at 13:37
@Weedoze 99.9% of the time, it's useful to convert. Personally, I have never used ===, but it is useful sometimes. — Feathercrown, Oct 07 '16 at 14:56

score 1 · Answer 1 · edited Oct 08 '16 at 00:56

1

In the if condition use === and not =

edited Oct 08 '16 at 00:56

Emile Bergeron

17,074
5
83
129

answered Oct 07 '16 at 13:29

fistuks

469
3
5

2

`===` (type comparision) – Xenos Oct 07 '16 at 13:31
@Xenos But why? What's the problem with ==? – Feathercrown Oct 07 '16 at 14:57
Because `' \n\n' == 0` is `true`. See http://stackoverflow.com/questions/523643/difference-between-and-in-javascript#523650 and https://www.impressivewebs.com/why-use-triple-equals-javascipt/ – Xenos Oct 07 '16 at 15:23
You are right type comparison is very important even though it means nothing to this question, It is still better to always use it as best practice. – fistuks Oct 07 '16 at 16:06
I changed the comment – fistuks Oct 07 '16 at 16:07

score 1 · Answer 2 · answered Oct 07 '16 at 13:32

Multiple errors where done :

You were using = (assign a value) instead of === (comparaison)
You miswrote trafficktick
Instead of doing var trafficktick = trafficktick + 1;. Simply do trafficktick++;

var trafficktick = 1;

function tick() {
  if (trafficktick === 1) {
    //tick1();
    console.log("Call tick1");
    trafficktick++;
  } else if (trafficktick === 2) {
    //tick2();
     console.log("Call tick2");
    trafficktick++;
  } else {
    trafficktick = 1;
  }
}

<button onclick="tick()">Click me</button>

score 0 · Answer 3 · answered Oct 07 '16 at 13:30

0

There's some errors in your JavaScript, try something like this:

<script>
    var trafficktick = 1; // Use var only here

    function tick() {

        // Use '==' or '===' depending on your logic operation to 
        // compare equality
        if (trafficktick == 1) { 

            // You want that? You can comment this call and call
            // it outside from an element (for example)
            tick1(); 
            traffictick ++; // Only '++' and no 'var' 

        } else if (trafficktick == 2) {

            tick2();
            traffictick ++; // Only '++' and no 'var'

        } else {

            trafficktick = 1; // No 'var'

        }
    } 
</script>

answered Oct 07 '16 at 13:30

RPichioli

3,245
2
25
29

I still get the same problem, it stays only runs tick1 and never tick2 :l – ReaP Oct 07 '16 at 13:39
Nvm i figured it out thanks :D – ReaP Oct 07 '16 at 13:40
@ReaP If you can not get it working you can try my working snipper answer – Weedoze Oct 07 '16 at 13:50
@ReaP your tick1() and tick2() calls the tick() function? The tick() function only route the calls based on the count and sum it (and by consequence you'll be in another condition in the next time) or set 1 again. Take care about the way you are working with the calls, we don't have it in this snippet. – RPichioli Oct 07 '16 at 13:53

HTML Button if script not working

3 Answers3