find closest marker to my current location

Question

I have an arrayList of markers and I want to find the closest marker to my current location. I had no idea how to find that marker so I searched and found same problem in here.

Google Maps Api v3 - find nearest markers

then I tried to convert those code to java but it doesn't work now.

closest doesn't change and always it is -1.

Is there any better solution for this problem or I can make the following code usable?

public void findNearMarker(){

    double pi = Math.PI;
    int R = 6371; //equatorial radius
    double[] distances = new double[2];
    double d = 0;
    int i;
    int closest = -1;

    for ( i = 0; i == markerArrayList.size(); i++){

        double lat2 = markerArrayList.get(i).getPosition().latitude;
        double lon2 = markerArrayList.get(i).getPosition().longitude;

        double chLat = lat2 - currentLocation.getLatitude();
        double chLon = lon2 - currentLocation.getLongitude();

        double dLat = chLat*(pi/180);
        double dLon = chLon*(pi/180);

        double rLat1 = currentLocation.getLatitude()*(pi/180);
        double rLat2 = lat2 * (pi/180);

        double a = Math.sin(dLat/2) * Math.sin(dLat/2) + Math.sin(dLon/2)
                * Math.sin(dLon /2) * Math.cos(rLat1) * Math.cos(rLat2);

        double c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1-a));

        d = R * c;

        distances[i] = d;
        if (closest == -1 || d< distances[closest]){
            closest = i;
        }
    }

}

You should take a look at : http://stackoverflow.com/questions/27379233/android-find-nearest-location-to-my-current-place — Ahmed Abidi, Oct 13 '16 at 16:38
Hint: use the Google Maps Android API Utility Library (check bottom of page) - https://developers.google.com/maps/documentation/android-api/utility/ — Morrison Chang, Oct 13 '16 at 16:39
This looks problematic: `i == markerArrayList.size()` inside your for loop. — geocodezip, Oct 16 '16 at 22:35

Tarek hemdan · Accepted Answer · 2016-12-29T15:07:32.780

first you need to import the location class of the android sdk

import android.location.Location;


 ArrayList<Marker> markers = new ArrayList<>();
markers = sortListbyDistance(markers, currentLocation.getLocation());


 public static ArrayList<Marker> sortListbyDistance(ArrayList<Marker> markers, final LatLng location){
        Collections.sort(markers, new Comparator<Marker>() {
            @Override
            public int compare(Marker marker2, Marker marker1) {
            //
                if(getDistanceBetweenPoints(marker1.getLocation(),location)>getDistanceBetweenPoints(marker2.getLocation(),location)){
                    return -1;
                } else {
                    return 1;
                }
            }
        });
        return markers;
    }


 public static float getDistanceBetweenPoints(double firstLatitude, double firstLongitude, double secondLatitude, double secondLongitude) {
        float[] results = new float[1];
        Location.distanceBetween(firstLatitude, firstLongitude, secondLatitude, secondLongitude, results);
        return results[0];
    }

and to get the nearest marker just get first item in markers, cheers :)

score 1 · Answer 2 · edited May 23 '17 at 11:46

If you follow Comparing two locations using their Longitude and Latitude

/** calculates the distance between two locations in MILES */
private double distance(double lat1, double lng1, double lat2, double lng2) {

double earthRadius = 3958.75; // in miles, change to 6371 for kilometer output

double dLat = Math.toRadians(lat2-lat1);
double dLng = Math.toRadians(lng2-lng1);

double sindLat = Math.sin(dLat / 2);
double sindLng = Math.sin(dLng / 2);

double a = Math.pow(sindLat, 2) + Math.pow(sindLng, 2)
    * Math.cos(Math.toRadians(lat1)) * Math.cos(Math.toRadians(lat2));

double c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1-a));

double dist = earthRadius * c;

return dist; // output distance, in MILES
}

loop through your list with this function and get the lowest return value.

You can also use the Maps API

 Location locationA = new Location("point A");

locationA.setLatitude(latA);
locationA.setLongitude(lngA);

Location locationB = new Location("point B");

locationB.setLatitude(latB);
locationB.setLongitude(lngB);

float distance = locationA.distanceTo(locationB);

here I have a list of distances and i can sort this list to get the lowest distance. But then how should i now which marker had this lowest distance?? — Mohsen Mohseni, Oct 14 '16 at 15:45

find closest marker to my current location

2 Answers2