Do-While don't working

Asked Oct 15 '16 at 00:13

Active Oct 15 '16 at 00:13

Viewed 20 times

I have some problem with WHILE, idk why.

do {
        url = find[o['random'].random(0, find.length)];
        sliced4 = url.slice(url.length-4,url.length);
        sliced5 = url.slice(url.length-5,url.length);
        c++;
        console.log(c+' '+sliced4+'-'+sliced5);
        if (c > 5) {
            o['bot'].send('Похоже, таких изображений не существует.', o['body'], {});
            return;
        }
    } while(sliced4 !== '.jpg' || sliced4 !== '.png' || sliced5 !== '.jpeg');

find[] contain links to images from Google.Images

Result from console(it's mean that code must working, because sliced4 == '.jpg'):

asked Oct 15 '16 at 00:13

Nick Deny

3

Simple answer: `||` should be `&&` – Barmar Oct 15 '16 at 00:19
1

BTW, you can get the last 4 characters with `url.substr(-4)`. – Barmar Oct 15 '16 at 00:20
@Barmar 3:21 on my clock, forget about this, ty. Also, ty with my question. C: – Nick Deny Oct 15 '16 at 00:22
Don't feel too bad. This is one of the most common mistakes made by new programmers. We see it in dozens of questions every day. – Barmar Oct 15 '16 at 00:33
1

A nicer way to check for your url extensions at the end -> `} while(['jpg','png','jpeg'].indexOf(a.split('.').slice(-1)[0]) >= 0))` – Keith Oct 15 '16 at 00:37

Do-While don't working

0 Answers0