Accessing method in one script from another script

Question

I have a pair of scripts I'm writing in C# in which one script calls a method from another script. However, I'm getting the following error:

Member 'PlayerActions.Attack()' cannot be accessed with an instance reference; qualify it with a type name instead

Here's where the method I want to call resides:

public class PlayerActions:MonoBehaviour{
    public static void Attack(){
        Debug.Log("Attacking");
    }
}

Here's where I'm trying to call the method:

public class Combat:MonoBehaviour{
    PlayerActions playerActions;
    void Start(){
        playerActions = GetComponent<PlayerActions>();
        playerActions.Attack();
    }
}

Both scripts are attached to the same Game Object.

Can anyone tell me how to fix the error I mentioned above and why I'm actually getting the error? I've always thought that you needed to reference the class you are trying to gain access to, but from what I'm understanding, this error is stating otherwise.

Why don't you try throwing away the `static` modifier? `public void Attack()` — Cù Đức Hiếu, Oct 19 '16 at 19:14
Yes - do just what it says. Use the type name instead of the instance since it is a static method. — pstrjds, Oct 19 '16 at 19:14
@CùĐứcHiếu I did that right as you were making the comment and it fixed it. IF you want, make that an answer and I'll mark it as accepted. — Robert, Oct 19 '16 at 19:15

score 5 · Accepted Answer · answered Oct 19 '16 at 19:16

5

Remove the static modifier and your code will work!

public class PlayerActions:MonoBehaviour{
    public void Attack(){
        Debug.Log("Attacking");
    }
}

answered Oct 19 '16 at 19:16

Cù Đức Hiếu

5,569
4
27
35

Accessing method in one script from another script

1 Answers1