Display particular loggedin user name

Question

I want to display the particular username after login successful. by using session I am calling my username. But it is displaying all user names.

Please give suggestion to display only particular username. Here is my code.

In session :

$_SESSION ['admin_name'] = $row['name'];
$admin_name = $_SESSION['admin_name'];

Inserting in to DB :

 $sql = "INSERT INTO account_info (name)
         VALUES ( '$admin_name')";

Displaying :

<?php
    $count = 1;
    $sel_query = "Select * from account_info ORDER BY id;";
    $result = mysql_query($sel_query);
    while ($row = mysql_fetch_assoc($result)) { 
?>
        <td align="left"><?php echo $row["name"]; ?></td>
<?php 
        $count++; 
    }
?>

I think while displaying I need to filter name. Please reply to me anybody knows how to filter.

Update:

enter image description here

In your select query, you need to use WHERE to select the user u want ! and also remove ";" after id in your query ! — Sinf, Oct 21 '16 at 09:36
For info: as I can see, you are new in PHP, so don't use MySQL_, learn PDO which is easier and more secure if you use it correctly ! — Sinf, Oct 21 '16 at 09:46
@Soheyl: yah u r right, try to use prepared statement this will help u to prevent SQL attack — devpro, Oct 21 '16 at 09:47

score 0 · Answer 1 · answered Oct 21 '16 at 09:36

You should re-approach this as it's poor design, but to get what you want to achieve:

while($row = mysql_fetch_assoc($result)) {
    if($row['name'] == $_SESSION['admin_name']) {
        ...
    }
}

Or even better...

$sel_query="Select name from account_info WHERE name = '$admin_name'";

Twinfriends · Answer 2 · 2016-10-21T09:48:33.470

0

$sel_query="Select * from account_info WHERE name = '$admin_name' ";

edited Oct 21 '16 at 09:48

answered Oct 21 '16 at 09:36

Twinfriends

1,972
1
14
34

score 0 · Answer 3 · answered Oct 21 '16 at 10:52

You don't need to save session values into database to show it after login successful.

Only store it into session array like this:

$_SESSION['user_name'] = $row['name'];

and in login page check this session array is set or not.If set then display it like:

if(isset($_SESSION['user_name'])) { echo $_SESSION['user_name']; }

score -1 · Answer 4 · edited May 23 '17 at 10:32

-1

You are getting the all username because of this query:

Select * from account_info ORDER BY id;

This will return all user data, you need to add username in WHERE clause for particular user as:

Select * from account_info WHERE name = '$admin_name';

More important, i didn't see session_start() function in your code, don't forgot to use this, otherwise you can't get the $_SESSION values.

Other important thing, your code is open for SQL Injection, you can use Prepared Statement for preventing SQL Attack. This will help you: How can I prevent SQL injection in PHP?

Very Special point, mysql_* is deprecated and closed in PHP 7.

Side Notes:

In your current query, no need to use ORDER BY id because when you use WHERE for particular user this part should be useless here.

Don't know, where are you using $count++; in your requirement, you need to print only particular user data so this is also useless here.

edited May 23 '17 at 10:32

Community

1
1

answered Oct 21 '16 at 09:43

devpro

16,184
3
27
38

Thanks for the answer, – Keerthi Oct 21 '16 at 10:07
I have session_start(). – Keerthi Oct 21 '16 at 10:13
But if i write Select * from account_info WHERE name = '$admin_name'; – Keerthi Oct 21 '16 at 10:13
@Keerthi: u need to check your values `$admin_name` – devpro Oct 21 '16 at 10:17
@Keerthi: `print_r($_SESSION);` use this and share the result – devpro Oct 21 '16 at 10:17
If I write Select * from account_info all names are showing. I don't think it is problem with name – Keerthi Oct 21 '16 at 10:19
u want to display specific user info which name available in session @Keerthi `print_r($_SESSION);` and share the result before your query – devpro Oct 21 '16 at 10:21
@Keerthi: did u checked? – devpro Oct 21 '16 at 10:29
I have added my output image.I ma getting all names as shown in the picture. Where i can write print_r($_SESSION); – Keerthi Oct 21 '16 at 10:29
@Keerthi: add before your query and you will get an array please share the result – devpro Oct 21 '16 at 10:32

Display particular loggedin user name

4 Answers4