I can't figure this out, my script has an issue

Question

   window.onkeydown = function(e) {
     var code = e.keyCode ? e.keyCode : e.which;
     if (code === 71) {
       alert("hi");
     }
   };



   window.onkeyup = function(e) {
     var code = e.keyCode ? e.keyCode : e.which;
     if (code === 69) {
       alert("hi");
     }
   };

dont mind the following text!! I thought this would be answered somewhere on SO, but I can't find it.

If I'm listening for a keypress event, should I be using .keyCode or .which to determine if the enter key was pressed?

I've always done something like the following:dont mind this text!!

Please read [ask] and [mcve], and [edit] your question accordingly. — Felix Kling, Oct 22 '16 at 17:11
Why in the world did you create an image with your question's text instead of just typing it? — j08691, Oct 22 '16 at 17:13

score -1 · Accepted Answer · answered Oct 22 '16 at 17:18

-1

something like this..

window.onload = function(e) {

  window.addEventListener('keydown', function (e) {
      console.log('keydown: ' + e.keyCode);
      if (e.keyCode == 71) {
        alert("hi");
      }
  });


  window.addEventListener('keyup', function (e) {
      console.log('keyup: ' + e.keyCode);
      if (e.keyCode == 69) {
         alert("hi");
      }
  });

}

answered Oct 22 '16 at 17:18

Donald Wu

698
7
20

exactly what i was looking for thx a lot. – creepy uncle herbert... Oct 22 '16 at 18:18
*"something like this.."* doesn't really mean anything. Are you saying that the OP should use `keyCode` and not `which`? If yes, why? If you don't elaborate, no one can learn anything. – Felix Kling Oct 22 '16 at 20:37

I can't figure this out, my script has an issue

1 Answers1