App Crashing when trying to set textView

Question

Hi so I'm brand new to programming. So the app I'm working on is a listView that is populated with an array. I added a listener so that when an item is selected from the list it opens up a new activity. Now the content of the new activity is based on which item is selected. I'm able to start the new activity from selecting list items. But when I try and set the textview of the new activity the app stops running. I've looked through a lot of related posts but still can't figure out how to set the text.

Heres my MainActivity.java

    package com.example.zach.listview;

import android.content.Intent;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.AdapterView;
import android.widget.ArrayAdapter;
import android.widget.ListAdapter;
import android.widget.ListView;
import android.widget.TextView;
import  android.widget.Toast;
import static com.example.zach.listview.R.id.routeDetailsView;

public class MainActivity extends AppCompatActivity {

public static String[] routes = {"Information","Crag Map","Main Wall","1. Shark Bait - 5.9", "2. Rain Check - 5.8", "3. Rain Check Direct - 5.7+",
        "4. Arocknophobia - 5.7", "5. Balls Deep - 5.9+", "6. Jingle Bells - 5.9", "7. Itching to Climb - 5.8-", "8. Hog Nose 5.10+",
        "9. Slab Dance - 5.10", "10. Don't Screw with My Disco - 5.11c"};

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    //TextView for route details
    final TextView routeDetailsView = (TextView) findViewById(R.id.routeDetailsView);

    ListAdapter routeAdapter = new CustomAdapter(this, routes);
    final ListView routeListView = (ListView) findViewById(R.id.routeListView);
    routeListView.setAdapter(routeAdapter);



    routeListView.setOnItemClickListener(
            new AdapterView.OnItemClickListener() {
                @Override
                public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
                    String route = String.valueOf(parent.getItemAtPosition(position));

                    if (route == "1. Shark Bait - 5.9") {
                        Intent routeDetails = new Intent(view.getContext(), RouteDetails.class);
                        startActivity(routeDetails);
                        routeDetailsView.setText("Shark Bait - 5.9");

                    }

                }

            }


    );


  }
}

Heres My activity_main.xml

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/activity_main"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingBottom="@dimen/activity_vertical_margin"
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
android:paddingTop="@dimen/activity_vertical_margin"
tools:context="com.example.zach.listview.MainActivity">


<ListView
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:layout_alignParentTop="true"
    android:layout_alignParentLeft="true"
    android:layout_alignParentStart="true"
    android:layout_marginTop="24dp"
    android:id="@+id/routeListView" />
</RelativeLayout>

Heres my RouteDetails.java

package com.example.zach.listview;

import android.content.Intent;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.AdapterView;
import android.widget.TextView;
import static com.example.zach.listview.MainActivity.routes;

public class RouteDetails extends AppCompatActivity {

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_route_details);

    //TextView for route details
   final TextView routeDetailsView = (TextView)findViewById(R.id.routeDetailsView);



    //if(route == "1. Shark Bait - 5.9"){
    //routeDetailsView.setText("Shark Bait - 5.9");
//}


}
}

and my activity_route_details.xml

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/activity_route_details"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingBottom="@dimen/activity_vertical_margin"
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
android:paddingTop="@dimen/activity_vertical_margin"
tools:context="com.example.zach.listview.RouteDetails">

<TextView
    android:text="TextView"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_alignParentTop="true"
    android:layout_centerHorizontal="true"
    android:layout_marginTop="14dp"
    android:id="@+id/routeDetailsView" />
 </RelativeLayout>

I really appreciate any help!

edit: here my customAdapter.java

package com.example.zach.listview;

import android.content.Context;
import android.support.annotation.MainThread;
import android.support.annotation.NonNull;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.AdapterView;
import android.widget.ArrayAdapter;
import android.widget.ListAdapter;
import android.widget.ListView;
import android.widget.TextView;
import  android.widget.Toast;
import com.example.zach.listview.MainActivity;

/**
* Created by Zach on 11/3/2016.
*/

class CustomAdapter extends ArrayAdapter<String>{

public CustomAdapter(Context context, String[] routes) {
    super(context, R.layout.custom_row ,routes);
}

@NonNull
@Override
public View getView(int position, View convertView, ViewGroup parent) {

    LayoutInflater routeInflater = LayoutInflater.from(getContext());
    View customView = convertView;
    if(customView == null){customView =     routeInflater.inflate(R.layout.custom_row, parent, false);}

    String singleRoute = getItem(position);
    TextView routeText = (TextView) customView.findViewById(R.id.routeText);

    //for adding count numbers to listView
    //int pos = position+1;
    //routeText.setText(+pos + ". " +  MainActivity.routes [position]);
    //pos++;

    routeText.setText(singleRoute);
    return customView;
}
}

and my error message

E/AndroidRuntime: FATAL EXCEPTION: main
              Process: com.example.zach.listview, PID: 3137
              java.lang.NullPointerException: Attempt to invoke virtual    method 'void android.widget.TextView.setText(java.lang.CharSequence)' on a null object reference
                  at com.example.zach.listview.MainActivity$1.onItemClick(MainActivity.java:51)
                  at android.widget.AdapterView.performItemClick(AdapterView.java:310)
                  at android.widget.AbsListView.performItemClick(AbsListView.java:1155)
                  at  android.widget.AbsListView$PerformClick.run(AbsListView.java:3126)
                  at android.widget.AbsListView$3.run(AbsListView.java:4041)
                  at android.os.Handler.handleCallback(Handler.java:751)
                  at android.os.Handler.dispatchMessage(Handler.java:95)
                  at android.os.Looper.loop(Looper.java:154)
                  at android.app.ActivityThread.main(ActivityThread.java:6077)
                  at java.lang.reflect.Method.invoke(Native Method)
                  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
                  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

Application terminated.

_Now the content of the new activity is based on which item is selected._ If this is the case, you need to pass that information to your `RouteDetails` activity via the intent. — pathfinderelite, Nov 04 '16 at 18:52

score 1 · Answer 1 · answered Nov 04 '16 at 18:54

1

You must send data between Activity by Intent :
For send :

        Intent routeDetails = new Intent(view.getContext(), RouteDetails.class);
        routeDetails.putExtra("value","Shark Bait - 5.9");
        startActivity(routeDetails);

And To get Data in other Activity:

        routeDetailsView.setText(getIntent().getExtras().getShort("value"))

answered Nov 04 '16 at 18:54

Soheil Tayyeb

315
4
13

Hi thank you but I cannot get that to work. I get the same app crashing saying listview has stopped – user4297729 Nov 04 '16 at 19:37
Hey thank you I was able to Get it to work! – user4297729 Nov 04 '16 at 20:22

App Crashing when trying to set textView

1 Answers1