How to insert multiple image file in a row on my database

Question

if(count($_FILES['upload']['name']) > 0){ 

    //Loop through each file 
    for($i=0; $i<count($_FILES['upload']['name']); $i++) { 

        //Get the temp file path 
        $tmpFilePath = $_FILES['upload']['tmp_name'][$i]; 

        //Make sure we have a filepath 
        if($tmpFilePath != ""){ 

            //save the filename 
            $shortname = $_FILES['upload']['name'][$i]; 

            //save the url and the file 
            $filePath = "../img/slider/" .$_FILES['upload']['name'][$i]; 

            //Upload the file into the temp dir             
            if(move_uploaded_file($tmpFilePath, $filePath)) { $files[] = $shortname; 


            } 
        } 
    } 
}

if(is_array($files)){ 

    foreach($files as $file){


        $file1 = "img/slider/" . $file; 
        $query = "INSERT INTO image(image_path,p_number)VALUES('$file1','$number')";
        $result3 = $db->insert($query);
    } 
}

How can I add implode? to store in my database as a 1 record only. because this is generating record each of file my file upload.

the first image is my current database look like. and the second is my goal. how can I do that?

I'm not sure I understand the question? Should all file data be stored in one single row? Edit your question and add an example of how you would like the row to look in your database. And what is `$number`? — Cyclonecode, Nov 10 '16 at 08:28
_How_ should those paths and numbers be imploded so that they can still be used afterwards? Certainly keeping those entries separate is a very good thing. That is how relation databases are meant to be used. — arkascha, Nov 10 '16 at 08:29
And by the way: your code is vulnerable to sql injection attacks. You do _not_ want to use the client side specified file name for your local storage. First because of said injection attacks and Second because the same file name might get used multiple times, you'd have a collision. You want to compute an internal file name based on the current timestamp and maybe a user id. — arkascha, Nov 10 '16 at 08:30
http://stackoverflow.com/questions/3653462/is-storing-a-delimited-list-in-a-database-column-really-that-bad/3653574 — e4c5, Nov 10 '16 at 09:00

score 0 · Answer 1 · answered Nov 10 '16 at 09:39

Beside it should for the most scenarios not the best way to store multiple values into a single row-column, you can update the column if the p_number (used as primary key) are already exists on insert:

INSERT INTO image(image_path,p_number)VALUES('$file1','$number')
ON DUPLICATE KEY UPDATE image_path = CONCAT(image_path, ',', $file1);

score 0 · Accepted Answer · answered Nov 10 '16 at 09:43

0

According to your requirement, you can change your code like this:

if(is_array($files)){ 
       $completeFileName = implode(',',$files);       
       $query = "INSERT INTO image(image_path,p_number)VALUES('$completeFileName','$number')";
        $result3 = $db->insert($query);
}

answered Nov 10 '16 at 09:43

Anshul

116
1
10

it's working. But How could I display only one image then? – oo7 Nov 11 '16 at 05:34
You can do reverse process for display into front end. If my answer works according to your question then please accept it. – Anshul Nov 11 '16 at 06:46
– oo7 Nov 11 '16 at 06:54
that's my code. but it display two image. I want to display one only. – oo7 Nov 11 '16 at 06:55
Like if your images are image1.jpg,image2.jpg ....... . So which image you want to display? First image image1.jpg. – Anshul Nov 11 '16 at 07:03
No need for foreach loop here you can directly access your first image like this: $field[0]; – Anshul Nov 11 '16 at 07:15
it's working with a single image name store in DB. but not in two name seperated with comma. – oo7 Nov 11 '16 at 07:36

score 0 · Answer 3 · answered Nov 10 '16 at 09:46

0

Use PHP Implode

if(is_array($files)){ 
$query = "INSERT INTO image(image_path,p_number)VALUES('".implode(",", $files)."','$number')";
}

Sidenote: You are storing img/slider for all images. You can remove that and store as Penguins,Jellyfish alone in your DB against the number and where you display the image you can append it to the src. You can reduce the size of the table.

answered Nov 10 '16 at 09:46

Sarvap Praharanayuthan

4,212
7
47
72

Noted. Thank you. – oo7 Nov 11 '16 at 05:46

How to insert multiple image file in a row on my database

3 Answers3