0

Can you help me on how to make this script work.

For Defrag

import os;
defragmentation=os.popen('defrag.exe /C').read()
print(defragmentation);

For Disk Clean up

import os;
clean=os.popen('cleanmgr.exe /sagerun:1').read()
print(clean);

Upon trying this scripts, it didnt do anything and no error message prompt. Thank you.

Aouie
  • 119
  • 2
  • 8
  • 17

3 Answers3

1
  • If your defrag.exe or cleanmgr.exe are not in your path, they won't execute and you won't get an error message
  • You would need to run the scripts as an administrator to make them work.
  • You don't need to terminate your lines with a semi-colon in Python

If you want to find the the correct full path of your executable, you can use the following script:

paths = os.getenv('path').split(';')
path_defrag = ''

for p in paths:
    if os.access(os.path.join(p, 'defrag.exe'), os.X_OK):
        path_defrag = os.path.join(p, 'defrag.exe')
        break
if not path_defrag:
    print('defrag.exe is not in your path or cannot be executed')
  • I'd suggest to Spectras' idea and read the output while it comes and not once everything is finished
  • In addition I think Python is an overkill here, a simple batch file will do the job
Maximilian Peters
  • 30,348
  • 12
  • 86
  • 99
  • `>>> os.popen('foobar')` gives `sh: 1: foobar: not found`. Don't know about windows, but on Ubuntu it certainly writes an error message onto stderr. – spectras Nov 12 '16 at 06:17
  • @spectras: Windows and Ubuntu are different here. On Windows it just gives back an empty string if the program is not found. – Maximilian Peters Nov 12 '16 at 06:18
  • im running in Windows by the way. – Aouie Nov 12 '16 at 06:18
  • @MaximilianPeters - hey bro, how can i determine if it is not in my path. can you help me build a script for disk clean up and disk defrag? Im running in windows OS – Aouie Nov 12 '16 at 06:19
  • @MaximilianPeters> interesting flaw. Anyway, my bet here is the script works perfectly, but @user2926827 expects to see output right away and, not seeing any, aborts the program. However, due to calling `read()` and printing after, no output will ever be displayed until **after** the command has completed. – spectras Nov 12 '16 at 06:20
  • @user2926827: welcome to Stackoverflow! Please have a look at: http://meta.stackoverflow.com/questions/262119/the-use-of-gender-specific-pronouns-on-stack-overflow – Maximilian Peters Nov 12 '16 at 06:59
0

Building upon my comment: my bet here is the script works perfectly, but you expect to see output right away and, not seeing any, abort the program.

However, read() will stop your script until the command completes. And only then will the pringint happen. Thus, no output will ever be displayed until after the command has completed.

I would change it like this:

with os.popen('cleanmgr.exe /sagerun:1') as fd:
    chunks = iter(lambda: fd.read(1), '')
    for chunk in chunks:
        sys.stdout.write(chunk)

The idea being to print as it goes: when a size is specified, read does not loop until the descriptor is closed, it returns as soon as it reads something.

It's not the most efficient here as it will read chars one by one. For the programs you're running it should not matter much, and reading more without introducing buffering delays with python is complex.

If you are not using the output in your program and just want it to pass through, maybe you'd be better off just calling :

import subprocess
subprocess.check_call(['cleanmgr.exe', '/sagerun:1'])

With no additional parameters, output will just go to your script's output. The function waits until the command completes before returning.

spectras
  • 13,105
  • 2
  • 31
  • 53
  • 1
    @user2926827> see the suggestion I added of using [`check_call()`](https://docs.python.org/3/library/subprocess.html#subprocess.check_call) by the way, if you don't actually need the output inside your script, it's much simpler. – spectras Nov 12 '16 at 06:43
  • thank you for editing the script. however can you add on the code that once the disk clean up is done it will show a notification on users screen that it has been finished? – Aouie Nov 13 '16 at 03:46
  • Just print whatever you want after `check_call` returns. But maybe your issue is [the window closes immediately](http://stackoverflow.com/questions/1000900/how-to-keep-a-python-script-output-window-open)? – spectras Nov 13 '16 at 18:20
  • Hi Spectras. Can you please check the Disk Defrag script? thank you. – Aouie Nov 17 '16 at 05:43
  • @user2926827> I checked it out, and actually reading more than 1 byte at a time in python without introducing buffering delay makes complex code. Did you try simply using the `subprocess.check_call` thing? It's one line, it lets the output go to the screen and it waits until the command has completed. You can just do whatever you want after, including writing stuff or sending email. If on Windows for instance, try adding a single `input()` at the end to prevent the window from closing immediately. – spectras Nov 17 '16 at 18:33
  • thanks man for the reply. Can you write the script for me? I want to run the script on Windows 7 and Windows 10 both 64 and 32 bit. Thanks for your help. – Aouie Nov 18 '16 at 00:46
  • @user2926827> Sorry, but nope, SO is not a coding service. While we can go great lengths to help people with their code, we won't write it for them. – spectras Nov 18 '16 at 10:04
0

the problem you face is because you are trying to launch 64-bit executable out of 32-bit process. When your python or cmd prompt you launch the scripts is 32-bit, it will launch defrag.exe in 32-bit mode if you just specify defrag.exe alone without full path.

And cleanmgr does not return anything, you should just get an empty string back. Try code below, it should works for both python 32-bit or 64-bit targeting 64-bit OS

import os
print('running disk defragmentation, this might take some time ...')
# you might wanna try out with %systemroot%\sysnative\defrag.exe /A first,
# Else, it might really take some time for defragmentation
if sys.maxsize > 2**32:
    defragmentation=os.popen('defrag.exe /C').read() # run from 64-bit        
else:
    defragmentation=os.popen(r'%systemroot%\sysnative\defrag.exe /C').read() # run from 32-bit

print(defragmentation)


print('running disk cleanup, this might take some time ...')
clean=os.popen('cleanmgr.exe /sagerun:1').read() # should works in both 32-bit and 64-bit
print(clean) # cleanmgr run from gui and don't return anything, this should be empty

Suggest to use subprocess instead, os.popen is deprecated

import sys
import subprocess

if sys.maxsize > 2**32:
    run_cmd = 'defrag /C' # 64-bit python/cmd
else:
    run_cmd = r'%systemroot%\sysnative\defrag /C' # 32-bit python/cmd

output, err = subprocess.Popen(run_cmd, stdout=subprocess.PIPE, shell=True).communicate()
print(output)
if err:
    print('process fail, error {}'.format(err))
else:
    print('process sucess')

# repeat with run_cmd = 'cleanmgr /sagerun:1'
Skycc
  • 3,496
  • 1
  • 12
  • 18