How to stop foreach loop on c#

Question

XDocument doc = XDocument.Load(@"XMLFile1.xml");
Kullanıcılar _kullanici = new Kullanıcılar();
string password = pnb2.Password; 
foreach (XElement element2 in doc.Descendants("sif"))
{
    foreach (XElement element1 in doc.Descendants("iban"))
    {
        foreach (XElement element3 in doc.Descendants("accountno"))
        {
            foreach (XElement element4 in doc.Descendants("money"))
            {               
                foreach (XElement element8 in doc.Descendants("acc"))
                {
                    string val1 = element2.Value;
                    string val2 = element1.Value;
                    string val3 = element3.Value;
                    string val4 = element4.Value;
                    string val8 = element8.Value;
                    if (val8 == "1" && val1 == "Abdullah")
                    {                                               
                        lbl1.Content = ("İban Numaranız :" + val2);
                        lbl2.Content = ("Hesap Numaranız :" + val3);
                        lbl3.Content = ("Bakiyeniz :" + val4);
                    }
                }  
            }
        }
    }
}

How can I stop this loop ? If val8="1" and val1=="Abdullah" I would like to show my data on the screen but this loop is entering an endless loop so nothing shows on the screen.

@wudzik: Almost certainly not - if the OP wants to quit the whole 5-level-nested set of loops at that point, then putting it in a separate method and returning is probably the best approach. — Jon Skeet, Nov 16 '16 at 06:29
However, the code we've got here will *not* go into an endless loop... my guess is that there's something else wrong. — Jon Skeet, Nov 16 '16 at 06:30
@teovankot Careful, some people might think you are serious ;) — Manfred Radlwimmer, Nov 16 '16 at 06:43
Side note: you might want to consider using an XPath query instead of looping like this. — Emond, Nov 16 '16 at 06:44
Or a LINQ query. Note that it's unlikely that you *really* want to use `doc.Descendants` in every case - I'd expect `foreach (XElement element1 in element2.Descendants("iban"))` for example. Otherwise you've got 5 entirely independent sequences you're iterating over. — Jon Skeet, Nov 16 '16 at 06:47

score 2 · Accepted Answer · edited Nov 16 '16 at 06:45

2

Fixed error in this way:

if (val8 == "1" && val1 == "Abdullah")
{
    lbl1.Content = ("Iban Numaraniz :" + val2);
    lbl2.Content = ("Hesap Numaraniz :" + val3);
    lbl3.Content = ("Bakiyeniz :" + val4);
    return;
}

edited Nov 16 '16 at 06:45

Manfred Radlwimmer

13,257
13
53
62

answered Nov 16 '16 at 06:36

A.Gecu

93
2
12

1

Just change the val1 chekc in your first loop, this will give you performance boost: `if(element2.Value != "Abdullah") continue;` – mybirthname Nov 16 '16 at 06:42

score 2 · Answer 2 · answered Nov 16 '16 at 07:19

or you could try using "break" to stop the loop.

if (val8 == "1" && val1 == "Abdullah")
{                                               
     lbl1.Content = ("İban Numaranız :" + val2);
     lbl2.Content = ("Hesap Numaranız :" + val3);
     lbl3.Content = ("Bakiyeniz :" + val4);
     break; //stops the loop
}

Christos · Answer 3 · 2016-11-16T06:39:53.643

1

You could make use of a goto statement:

if (val8 == "1" && val1 == "Abdullah")
{
    lbl1.Content = ("İban Numaranız :" + val2);
    lbl2.Content = ("Hesap Numaranız :" + val3);
    lbl3.Content = ("Bakiyeniz :" + val4);
    goto Finished;
}

The label Finished should be placed after the closing bracket of the outer most foreach (XElement element2 in doc.Descendants("sif")). Something like the following does your job:

Finished: 
    ;

You could check this at dot-net-fiddle.

edited Nov 16 '16 at 06:39

answered Nov 16 '16 at 06:26

Christos

53,228
8
76
108

That will only break from the innermost loop, which probably isn't what's intended. – Jon Skeet Nov 16 '16 at 06:29
@Downvoter, I would appreciate if you could explain what's wrong. Thanks in advance. – Christos Nov 16 '16 at 06:46
@Christos that's the best answer :) – teo van kot Nov 16 '16 at 08:05

How to stop foreach loop on c#

3 Answers3