Can't bind to *ngFor error

Question

I'm trying to use *ngFor in my code. For some reason, I'm getting this error message when running the app:

I've triple checked all property names are good, and there aren't any directives in this case. I configured the app with the angular.io quickstart instructions.

This is my tsconfig:

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "removeComments": false,
    "noImplicitAny": false

  }
}

This is my package.json:

{
  "name": "angular-quickstart",
  "version": "1.0.0",
  "scripts": {
    "start": "tsc && concurrently \"tsc -w\" \"lite-server\" ",
    "lite": "lite-server",
    "tsc": "tsc",
    "tsc:w": "tsc -w"
  },
  "licenses": [
    {
      "type": "MIT",
      "url": "https://github.com/angular/angular.io/blob/master/LICENSE"
    }
  ],
  "dependencies": {
    "@angular/common": "~2.1.1",
    "@angular/compiler": "~2.1.1",
    "@angular/core": "~2.1.1",
    "@angular/forms": "~2.1.1",
    "@angular/http": "~2.1.1",
    "@angular/platform-browser": "~2.1.1",
    "@angular/platform-browser-dynamic": "~2.1.1",
    "@angular/router": "~3.1.1",
    "@angular/upgrade": "~2.1.1",
    "angular-in-memory-web-api": "~0.1.13",
    "core-js": "^2.4.1",
    "reflect-metadata": "^0.1.8",
    "rxjs": "5.0.0-beta.12",
    "systemjs": "0.19.39",
    "zone.js": "^0.6.25"
  },
  "devDependencies": {
    "@types/core-js": "^0.9.34",
    "@types/node": "^6.0.45",
    "concurrently": "^3.0.0",
    "lite-server": "^2.2.2",
    "typescript": "^2.0.3",
    "typings": "^2.0.0"
  }
}

This is my systemjs.config:

/**
 * System configuration for Angular samples
 * Adjust as necessary for your application needs.
 */
(function (global) {
  System.config({
    paths: {
      // paths serve as alias
      'npm:': 'node_modules/'
    },
    // map tells the System loader where to look for things
    map: {
      // our app is within the app folder
      app: 'app',
      // angular bundles
      '@angular/core': 'npm:@angular/core/bundles/core.umd.js',
      '@angular/common': 'npm:@angular/common/bundles/common.umd.js',
      '@angular/compiler': 'npm:@angular/compiler/bundles/compiler.umd.js',
      '@angular/platform-browser': 'npm:@angular/platform-browser/bundles/platform-browser.umd.js',
      '@angular/platform-browser-dynamic': 'npm:@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js',
      '@angular/http': 'npm:@angular/http/bundles/http.umd.js',
      '@angular/router': 'npm:@angular/router/bundles/router.umd.js',
      '@angular/forms': 'npm:@angular/forms/bundles/forms.umd.js',
      '@angular/upgrade': 'npm:@angular/upgrade/bundles/upgrade.umd.js',
      // other libraries
      'rxjs':                      'npm:rxjs',
      'angular-in-memory-web-api': 'npm:angular-in-memory-web-api/bundles/in-memory-web-api.umd.js'
    },
    // packages tells the System loader how to load when no filename and/or no extension
    packages: {
      app: {
        main: './main.js',
        defaultExtension: 'js'
      },
      rxjs: {
        defaultExtension: 'js'
      }
    }
  });
})(this);

This is the code where i'm using ngFor:

import {Component} from "@angular/core";

@Component({
    selector: 'semester-component',
    template: `
                <div class="semester-div">
                  <ul>
                    <li *ngFor="let subject of subjectsNames">
                      <span>
                       <input #subjectName type="text" />
                       <input id = "subjectGrade" type = "number"/>
                       <input id = "subjectWeight" type = "number"/>
                      </span>
                    </li>
                  </ul>
                  <br>
                  <button (click)="addSubject(subjectName.value)">add</button>
                  <br>
                </div>
`,
})

export class semesterComponent {
    subjectsNames = ["math"];

    addSubject(subjectName: string) {
     if (subjectName) {
     this.subjectsNames.push(subjectName);
     this.subjectsNames.slice();
     console.log(subjectName);
     console.log(this.subjectsNames);
     }

     };

This is the module file:

import { NgModule }      from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import {AppComponent} from "./app.component";
import {semesterModule} from './semester/semester.module';

@NgModule({
  imports:      [ BrowserModule, semesterModule],
  declarations: [AppComponent],
  bootstrap: [AppComponent]
})
export class AppModule { }

Please post code showing how you're using `ngFor` and your `@NgModule` class. — Brad, Nov 17 '16 at 06:23
The added code looks fine. How does the `NgModule` look like where this `semesterComponent` is part of? — Günter Zöchbauer, Nov 17 '16 at 17:30
Well this is embarrasing. I've imported BrowserModule only in the app.module, but not in the module where the semester component is declared. Thanks for the help!!! — Tal Geller, Nov 17 '16 at 17:35

score 4 · Answer 1 · answered Nov 16 '16 at 21:39

4

You need to add BrowserModule (if the component is in AppModule) otherwise CommonModule to imports: [] of your @NgModule()

@NgModule(
  imports: [BrowserModule, /* other imports */],
  ...
)

answered Nov 16 '16 at 21:39

Günter Zöchbauer

623,577
216
2,003
1,567

Hi, thanks for the very quick response. BrowserModule is actually already imported. – Tal Geller Nov 16 '16 at 21:40
Anyway you need to import the `CommonModule` into every module that uses standard directives. – Daniel Kucal Nov 17 '16 at 01:08
`BrowseeModule` includes `CommonModule`, so for the `AppModule` the former is enough. – Günter Zöchbauer Nov 17 '16 at 05:23
Did it solve your problem? – Günter Zöchbauer Dec 01 '16 at 06:09
thanks @GünterZöchbauer I had same problem and solved importing CommonModule. – nayakam Jul 13 '17 at 23:20

Can't bind to *ngFor error

1 Answers1

Linked