Passing a PHP variable into a Javascript funtion

Question

I have a variable named $path. I want to pass this variable from PHP to a javascript function.

<button onclick='myFunctionContact(\"" . $row1['id'] . "\")'>
    <img border='0' alt='Contacts' src='".$imgpth."peoplesmall.png'>
</button>
<script>
function myFunctionContact(id) {
    window.open('!!!$path should go here!!!'+id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
}
</script>

How do I get the URL in path to display inside of the function, in the desired place?

I tried printing the variable into a javascript variable and then placing that variable into the function, but the popup window no longer works when I do that.

function myFunctionContact(id) {
    var test1 = <?php echo $path; ?>;
    window.open(test1 +id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
 }

I Know I am doing it wrong, but I have no idea how. Any advice would be greatly appreciated.

Possible duplicate of [How to pass variables and data from PHP to JavaScript?](http://stackoverflow.com/questions/23740548/how-to-pass-variables-and-data-from-php-to-javascript) — giorgio, Nov 18 '16 at 07:34
The path needs to be a quoted string. The end result of your echoed string has to, itself, contain quotes. — ppovoski, Nov 18 '16 at 19:03

score 2 · Accepted Answer · answered Nov 18 '16 at 00:13

2

I think the problem is how you are echo the path:

Instead of:

var test1 = <?php echo $path; ?>

i think it should be

var test1 = <?php echo '"'.$path.'";'; ?>

answered Nov 18 '16 at 00:13

Ricardo Ortega Magaña

2,403
16
23

Is there a reason it works fine with var myValue = ; ? – Arthur Walker Nov 21 '16 at 03:35
1

json_encode return a string with the " (double quotes) character, thats whats missing in your code. – Ricardo Ortega Magaña Nov 21 '16 at 04:52

score 0 · Answer 2 · answered Nov 17 '16 at 23:37

0

You can always use a hidden input field, and set it's value to whatever you need to be used in your JS code, then grab that value of in your JS, or maybe try an ajax call to get the value you need.

answered Nov 17 '16 at 23:37

Saleh Al Eit

1

1

using a hidden input field is really bad practice. It works though. – giorgio Nov 18 '16 at 07:35

score 0 · Answer 3 · answered Nov 18 '16 at 01:08

0

json_encode() fixed the problem.

var myValue = <?php echo json_encode($path); ?>;

answered Nov 18 '16 at 01:08

Arthur Walker

125
10

1

Json is not meant to encode values to be inputted into a javascript variable. `json !== var` – giorgio Nov 18 '16 at 07:37

score 0 · Answer 4 · answered Nov 18 '16 at 19:11

The path needs to be a quoted string. The end result of your echoed string has to, itself, contain quotes.

Assuming $path is a string, window.open is expecting a quoted string as the parameter.

function myFunctionContact(id) {
    window.open(' . $path . ' + id, '', 'toolbar=no,scrollbars=yes,resizable=yes,top=200,left=500,width=400,height=400');
}
</script>

Passing a PHP variable into a Javascript funtion

4 Answers4