mysqli_query insert doesn't work

Question

$marka = $_POST['marka'];
$model = $_POST['model'];
$godiste = $_POST['godiste'];
$cena = $_POST['cena'];

$query = "INSERT INTO `auto` (`id`, `marka`, `model`, `godiste`, `cena`) VALUES (NULL, '$marka', '$model', '$godiste', '$cena');"

if(mysqli_query($connection,$query)) {
    echo "New record created";
} else {
    echo "Error: " . $query . "<br>" . mysqli_error($connection);
}

I can't find what is problem here:

Parse error: syntax error, unexpected 'if' (T_IF) in C:\wamp\www\autoplac\forma.php on line 16

Put a `;` after `$query = "INSERT INTO auto (id, marka, model, godiste, cena) VALUES (NULL, '$marka', '$model', '$godiste', '$cena');"` — Karim Harazin, Nov 19 '16 at 15:28

score 1 · Accepted Answer · answered Nov 19 '16 at 15:29

1

Do not stuff user-input values into query strings. The usual reason given is SQL injection -- and that is an important reason. An even better reason is that you can get unexpected syntax errors, because the content of the string interferes with the rest of the query.

It is easy enough to use parameters. Start with mysqli_prepare(). Here is a place in the documentation to start.

answered Nov 19 '16 at 15:29

Gordon Linoff

1,242,037
58
646
786

1

This is really a suggestion/comment. The actual issue here is the misplaced semi-colon in `'$cena');"` causing the parse error. `Parse error: syntax error, unexpected 'if' (T_IF)...` – Funk Forty Niner Nov 19 '16 at 15:54

score 0 · Answer 2 · answered Nov 19 '16 at 15:34

0

You forgot the semicolon AFTER the Double cuote in the query sentence

answered Nov 19 '16 at 15:34

Web App Developer Freelance

52
6

score -1 · Answer 3 · answered Nov 19 '16 at 15:27

Missing ; on end of line

$query = "INSERT INTO `auto` (`id`, `marka`, `model`, `godiste`, `cena`) VALUES (NULL, '$marka', '$model', '$godiste', '$cena');"

should be

$query = "INSERT INTO `auto` (`id`, `marka`, `model`, `godiste`, `cena`) VALUES (NULL, '$marka', '$model', '$godiste', '$cena');";

mysqli_query insert doesn't work

3 Answers3