Function opens too fast after a timeout in javascript

Asked Nov 20 '16 at 16:29

Active Nov 20 '16 at 16:33

Viewed 41 times

I am trying to make a Tapermonkeyscript, but someway the function opens itself way to often - it should do it every second - start and end are time stamps, so somehow the timeout isn't working right and I don't see the problem - can anyone please help?

function redefine(a) {
  var start = parent.mainFrame.start; //get start
  var end = parent.mainFrame.end; //get end
  var points = new Array(1, 2, 6, 3, 7, 3, 5, 3); //set array
  if (end - start <= 1) { //check if ready
    parent.mainFrame.setPoint(points[a]); //redefine point
    a = a + 1; //nextpoint
  }
  window.setTimeout(redefine(a), 1000); //check again in 1s for points
}
redefine(0);

Regards, basicn00b

edited Nov 20 '16 at 16:33

t.niese

39,256
9
74
101

asked Nov 20 '16 at 16:29

basicn00b

3

you should pass function reference,`window.setTimeout(function(){redefine(a)}, 1000); ` – Madhawa Priyashantha Nov 20 '16 at 16:30
@FastSnail and his function is inside timeout . will that cause problem ? – Mahi Nov 20 '16 at 16:32
It will most certainly cause the problem. Since the function is not passed by reference but executed. It will call `redefine` at the end of every `redefine` call, causing an infinite loop. @FastSnail I suggest you post an answer. – Maarten Bicknese Nov 20 '16 at 16:34
probably duplicate let's close it – Madhawa Priyashantha Nov 20 '16 at 16:35
Preferably, you should use an array literal `[1, 2, 6, 3, 7, 3, 5, 3]` rather than using the `Array` constructor. – 4castle Nov 20 '16 at 16:43
1

thanks for your help! – basicn00b Nov 20 '16 at 16:53

Function opens too fast after a timeout in javascript

0 Answers0