The row count function not getting executed but while loop works with in the if condition

Question

I'm writing a small script to retrieve yarn details from database. I use a ajax live search script to retrieve data from the database the basic while loop function works but I want to handle the empty results by submitting a massage to the results div tag.

I did went through the first post which was made about this matter but it didn't solve my problem that's why I ask this from the stacks community. And my problem is not about getting the row count my problem is why the if command is not working.

So in order to that I use the below PHP script.

$searchString = "SELECT yarnId FROM yarndetails WHERE yarnId LIKE concat('%',:searchStr,'%')";
$dbSql = $dbConnect->prepare($searchString);
$dbSql -> bindParam(':searchStr', $_GET["q"]);
$dbSql -> execute();

$getCount = "SELECT COUNT(*) FROM yarndetails WHERE yarnId LIKE concat('%',:sStr,'%')";
$dbCount = $dbConnect->prepare($getCount);
$dbCount -> bindParam(':sStr', $_GET["q"]);
$dbCount -> execute();
$dataCount = $dbCount -> rowCount();

if($dataCount = 1){
    while($row = $dbSql -> fetch(PDO::FETCH_ASSOC)) {
        echo $row['yarnId'] . "\n";
    }

}else{
        echo "No Data";
}

I searched StackOverfllow and found out best way to count the rows is to use that "SELECT count(8).." statement but there's something wrong with it some how the if condition passes through directly to the while loop.

Is there a better way to do this or am I missing something if can help please.

`if($dataCount = 1){` ... should that be `if($dataCount == 1){` - also, if you `select count(*)` you'll always get 1 record qith 1 column (being the count), so there will be no other info to loop through — Jaromanda X, Nov 23 '16 at 05:49

Your Common Sense · Answer 1 · 2016-11-23T07:15:07.220

$sql = "SELECT yarnId FROM yarndetails WHERE yarnId LIKE ?";
$stmt = $dbConnect->prepare($sql);
$stmt->execute(['%'.$_GET["q"].'%']);
$data = $stmt->fetchAll(PDO::FETCH_ASSOC);

if($data){
    echo json_encode($data);
}else{
    echo "No Data";
}

Given you are using it for AJAX, the condition is essentially superfluous too, as it should be a no-brainer to tell an empty array in JS. Making the last 5 rows just

echo json_encode($data);

The row count function not getting executed but while loop works with in the if condition

1 Answers1