Shared Preferences not saving data

Question

Initializing highScore array :

 score = 0;
 sharedPreferences = context.getSharedPreferences("Scores", Context.MODE_PRIVATE);
    //initialize the array of high scores
    highScore[0] = sharedPreferences.getInt("score1",0);
    highScore[1] = sharedPreferences.getInt("score2",0);
    highScore[2] = sharedPreferences.getInt("score3",0);
    highScore[3] = sharedPreferences.getInt("score4",0);
    highScore[4] = sharedPreferences.getInt("score5",0);

Checking For the 4 Highest Values :

highScore[5] = score;
Arrays.sort(highScore);

This is my code for saving data in shared preferences

SharedPreferences.Editor e = sharedPreferences.edit();
                for(int j=4;j>=0;j--){
                    e.putInt("score"+(j+1),highScore[j]);
                    e.apply();
                }

Please check here: http://stackoverflow.com/questions/23024831/android-shared-preferences-example — Babaji Pokharkar, Nov 23 '16 at 07:01
Have you initialized the sharedPreferences with the key "Scores"? — Madhav, Nov 23 '16 at 07:03
@NakulSudhakar Apply is faster than commit. They have the same functionality. — Madhav, Nov 23 '16 at 07:04

score 1 · Answer 1 · answered Nov 23 '16 at 07:05

1

I will suggest to use like that.

SharedPreferences pref;
pref= context.getSharedPreferences("Scores", Context.MODE_PRIVATE);
SharedPreferences.Editor e = pref.edit();
            for(int j=4;j>=0;j--){
                e.putInt("score"+(j+1),highScore[i]);
            }
            e.apply();

answered Nov 23 '16 at 07:05

Nitin Karande

1,280
14
33

My SharedPreferences object is public `public SharedPreferences sharedPreferences;` – JDFuzyll Nov 23 '16 at 07:22
@JDFuzyll Have you tried this? I would recommend loading the shared preferences object each time you go to use it. Not storing it globally. – IAmGroot Nov 23 '16 at 13:31
Thanks a lot It did Work – JDFuzyll Nov 23 '16 at 14:37
Very Happy to help you. @JDFuzyll – Nitin Karande Nov 23 '16 at 15:09

score 0 · Answer 2 · answered Nov 23 '16 at 07:27

Instead of commiting after completing the if loop , commit in each iteration of your loop like this:

SharedPreferences.Editor e = sharedPreferences.edit();
                for(int j=4;j>=0;j--){
                    e.putInt("score"+(j+1),highScore[i]);
                              e.apply();
  }

it will work.

Shared Preferences not saving data

2 Answers2