ListView will not populate data from Firebase

Question

My JSON:

{
    "Classes": {
        "host101": {
            "classID": "host101",
            "className": "host test",
            "days": ["monday", "wednesday", "friday"],
            "gpsLocation": "999",
            "roster": {
                "7MFUgOkcQbStn1nBFsVR4ZPWbmo2": {
                    "firstName": "Student",
                    "id": "7MFUgOkcQbStn1nBFsVR4ZPWbmo2",
                    "lastName": "test1",
                    "studentEmail": "ss@ss.com"
                }
            },
            "startTime": "2000",
            "teacherID": "Zb0cLGSz0YX5WYFSXPc4TJ5M8mf2"
        }
    },
    "Users": {
        "7MFUgOkcQbStn1nBFsVR4ZPWbmo2": {
            "Classes": {
                "host101": {
                    "classID": "host101",
                    "className": "host test",
                    "days": ["monday", "wednesday", "friday"],
                    "startTime": "2000"
                }
            },
            "firstName": "Student",
            "id": "7MFUgOkcQbStn1nBFsVR4ZPWbmo2",
            "lastName": "test1",
            "studentEmail": "ss@ss.com"
        },
        "Zb0cLGSz0YX5WYFSXPc4TJ5M8mf2": {
            "Hosted Classes": {
                "host101": {
                    "classID": "host101",
                    "className": "host test",
                    "days": ["monday", "wednesday", "friday"],
                    "gpsLocation": "999",
                    "roster": {
                        "7MFUgOkcQbStn1nBFsVR4ZPWbmo2": {
                            "firstName": "Student",
                            "id": "7MFUgOkcQbStn1nBFsVR4ZPWbmo2",
                            "lastName": "test1",
                            "studentEmail": "ss@ss.com"
                        }
                    },
                    "startTime": "2000",
                    "teacherID": "Zb0cLGSz0YX5WYFSXPc4TJ5M8mf2"
                }
            },
            "firstName": "Teacher",
            "id": "Zb0cLGSz0YX5WYFSXPc4TJ5M8mf2",
            "lastName": "test",
            "studentEmail": "tt@tt.com"
        }
    }
}

My code from TeacherClassDetail.class:

public class TeacherClassDetail extends AppCompatActivity {

    //in progress. teacher will set their question here and be able to take attendance and other teacher stuff...
    final DatabaseReference fbRef = FirebaseDatabase.getInstance().getReference();
    final FirebaseUser user = FirebaseAuth.getInstance().getCurrentUser();
    Button setQuestion;
    Button removeClass;
    TextView tvDetailName;
    TextView tvID;
    TextView tvStart;
    ListView lvDayList;
    ArrayList<String> dList = new ArrayList<String>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_teacher_class_detail);

        final ArrayAdapter<String> adapter = new ArrayAdapter<String>
                (this, android.R.layout.simple_list_item_1, dList);

        lvDayList = (ListView) findViewById(R.id.lvDays);
        setQuestion = (Button) findViewById(R.id.bSetQuestion);
        removeClass = (Button) findViewById(R.id.bRemoveClass);
        tvDetailName = (TextView) findViewById(R.id.tvCDetailName);
        tvID = (TextView) findViewById(R.id.tvCDetailID);
        tvStart = (TextView) findViewById(R.id.tvCDetailStart);

    }

    protected void onStart(){
        super.onStart();

        final ArrayAdapter<String> adapter = new ArrayAdapter<String>
                (TeacherClassDetail.this, android.R.layout.simple_list_item_1, dList);

        lvDayList.setAdapter(adapter);

        final String ID = getIntent().getStringExtra("ID");
        Query query = fbRef.child("Users").child(user.getUid()).child("Hosted Classes").child(ID);

        query.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(DataSnapshot dataSnapshot) {
                //getting string values
                Map<String, String> cl = (Map<String, String>) dataSnapshot.getValue();
                //getting arraylist values
                Map<String, ArrayList<String>> days = (Map<String, ArrayList<String>>) dataSnapshot.getValue();
                //getting arraylist of objects(roster)
                Map<String, Map<String, Object>> roster = (Map<String, Map<String, Object>>) dataSnapshot.getValue();

                //assigning that data to variables
                String id = cl.get("classID");
                String className = cl.get("className");
                String gpsLocation = cl.get("gpdLocation");
                String startTime = cl.get("startTime");
                dList = new ArrayList<String>(days.get("days"));
                adapter.notifyDataSetChanged();
                String teacherID = cl.get("teacherID");

                //creating ClassObj for use in student "my classes" list
                ClassObj newClass = new ClassObj(className, id, startTime, dList, gpsLocation);

                tvDetailName.setText("Class Name: " + newClass.getClassName());
                tvID.setText("Class ID: " + newClass.getClassID());
                tvStart.setText("Start Time(MilTime): " + newClass.getStartTime());


            }

            @Override
            public void onCancelled(DatabaseError databaseError) {

            }
        });

    }
}

The ListView (lvDayList) will not populate though the textviews are populating just fine. I have tried initializing the arraylist dList in a few different places. I think it has something to do with how im populating the dList but i am not sure of the correct way to do so if it is done wrong. If that is not the issue than I am kind of drawing a blank here. Any help is appreciated

score 0 · Answer 1 · answered Nov 25 '16 at 03:46

0

SOLVED: had to change the line in onDataChange() from dList = new ArrayList<String>(days.get("days")); to dList.addAll(days.get("days"));

answered Nov 25 '16 at 03:46

ThePeskyWabbit

417
1
7
23

score 0 · Answer 2 · answered Nov 25 '16 at 03:47

0

Try this code inside onDataChange,

...
String startTime = cl.get("startTime");

dList.clear();
dList.addAll(days.get("days"));
adapter.notifyDataSetChanged();

String teacherID = cl.get("teacherID");
...

answered Nov 25 '16 at 03:47

K Neeraj Lal

6,768
3
24
33

Nice. Good luck :) – K Neeraj Lal Nov 25 '16 at 03:48

score 0 · Accepted Answer · edited May 23 '17 at 12:13

You should not reinitialize the dList because the listview holds a reference for the dataset you used when instantiating the adapter. So, when you call adapter.notifyDataSetChanged(), it uses the existing reference of the list. When you reinitialise the list, it will have no effect. You need to clear the list and add the values to the list and then call adapter.notifyDataSetChanged();. Please refer this SO link for details: https://stackoverflow.com/a/23195575/6452886

I just modified your code for understanding:

public class TeacherClassDetail extends AppCompatActivity {

    //in progress. teacher will set their question here and be able to take attendance and other teacher stuff...
    final DatabaseReference fbRef = FirebaseDatabase.getInstance().getReference();
    final FirebaseUser user = FirebaseAuth.getInstance().getCurrentUser();
    Button setQuestion;
    Button removeClass;
    TextView tvDetailName;
    TextView tvID;
    TextView tvStart;
    ListView lvDayList;
    ArrayList<String> dList = new ArrayList<String>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_teacher_class_detail);

        final ArrayAdapter<String> adapter = new ArrayAdapter<String>
                (this, android.R.layout.simple_list_item_1, dList);

        lvDayList = (ListView) findViewById(R.id.lvDays);
        setQuestion = (Button) findViewById(R.id.bSetQuestion);
        removeClass = (Button) findViewById(R.id.bRemoveClass);
        tvDetailName = (TextView) findViewById(R.id.tvCDetailName);
        tvID = (TextView) findViewById(R.id.tvCDetailID);
        tvStart = (TextView) findViewById(R.id.tvCDetailStart);

    }

    protected void onStart(){
        super.onStart();

        final ArrayAdapter<String> adapter = new ArrayAdapter<String>
                (TeacherClassDetail.this, android.R.layout.simple_list_item_1, dList);

        lvDayList.setAdapter(adapter);

        final String ID = getIntent().getStringExtra("ID");
        Query query = fbRef.child("Users").child(user.getUid()).child("Hosted Classes").child(ID);

        query.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(DataSnapshot dataSnapshot) {
                //getting string values
                Map<String, String> cl = (Map<String, String>) dataSnapshot.getValue();
                //getting arraylist values
                Map<String, ArrayList<String>> days = (Map<String, ArrayList<String>>) dataSnapshot.getValue();
                //getting arraylist of objects(roster)
                Map<String, Map<String, Object>> roster = (Map<String, Map<String, Object>>) dataSnapshot.getValue();

                //assigning that data to variables
                String id = cl.get("classID");
                String className = cl.get("className");
                String gpsLocation = cl.get("gpdLocation");
                String startTime = cl.get("startTime");
                dList.clear();
                dList.addAll(days.get("days”));
                adapter.notifyDataSetChanged();

                              String teacherID = cl.get("teacherID");

                //creating ClassObj for use in student "my classes" list
                ClassObj newClass = new ClassObj(className, id, startTime, dList, gpsLocation);

                tvDetailName.setText("Class Name: " + newClass.getClassName());
                tvID.setText("Class ID: " + newClass.getClassID());
                tvStart.setText("Start Time(MilTime): " + newClass.getStartTime());


            }

            @Override
            public void onCancelled(DatabaseError databaseError) {

            }
        });

    }
}

Kiran Dsouza · Answer 4 · 2016-11-25T04:57:20.617

Try this code you are multiple time initialized adapter and it has to globally initialize it.

public class TeacherClassDetail extends AppCompatActivity {

        //in progress. teacher will set their question here and be able to take attendance and other teacher stuff...
        final DatabaseReference fbRef = FirebaseDatabase.getInstance().getReference();
        final FirebaseUser user = FirebaseAuth.getInstance().getCurrentUser();
        Button setQuestion;
        Button removeClass;
        TextView tvDetailName;
        TextView tvID;
        TextView tvStart;
        ListView lvDayList;
        ArrayAdapter<String> adapter;
        ArrayList<String> dList = new ArrayList<String>();

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_teacher_class_detail);
            lvDayList = (ListView) findViewById(R.id.lvDays);
            setQuestion = (Button) findViewById(R.id.bSetQuestion);
            removeClass = (Button) findViewById(R.id.bRemoveClass);
            tvDetailName = (TextView) findViewById(R.id.tvCDetailName);
            tvID = (TextView) findViewById(R.id.tvCDetailID);
            tvStart = (TextView) findViewById(R.id.tvCDetailStart);
            adapter = new ArrayAdapter<String>
                    (this, android.R.layout.simple_list_item_1, dList);
             lvDayList.setAdapter(adapter);

        }

        protected void onStart(){
            super.onStart();



            final String ID = getIntent().getStringExtra("ID");
            Query query = fbRef.child("Users").child(user.getUid()).child("Hosted Classes").child(ID);

            query.addValueEventListener(new ValueEventListener() {
                @Override
                public void onDataChange(DataSnapshot dataSnapshot) {
                    //getting string values
                    Map<String, String> cl = (Map<String, String>) dataSnapshot.getValue();
                    //getting arraylist values
                    Map<String, ArrayList<String>> days = (Map<String, ArrayList<String>>) dataSnapshot.getValue();
                    //getting arraylist of objects(roster)
                    Map<String, Map<String, Object>> roster = (Map<String, Map<String, Object>>) dataSnapshot.getValue();

                    //assigning that data to variables
                    String id = cl.get("classID");
                    String className = cl.get("className");
                    String gpsLocation = cl.get("gpdLocation");
                    String startTime = cl.get("startTime");
                   // dList = new ArrayList<String>(days.get("days"));
                    dList.clear();//clear your list
                    dList.add(days.get("days")); // add to the list
                    adapter.notifyDataSetChanged();
                    String teacherID = cl.get("teacherID");

                    //creating ClassObj for use in student "my classes" list
                    ClassObj newClass = new ClassObj(className, id, startTime, dList, gpsLocation);

                    tvDetailName.setText("Class Name: " + newClass.getClassName());
                    tvID.setText("Class ID: " + newClass.getClassID());
                    tvStart.setText("Start Time(MilTime): " + newClass.getStartTime());


                }

                @Override
                public void onCancelled(DatabaseError databaseError) {

                }
            });

        }
    }

We need to clear the data set and then add the data. Otherwise, the size of the data set goes long. — Madhan, Nov 25 '16 at 04:23
ya its best practice clear list normally it not effect data size because data adding in onstart method and onstart is not executing every time if you call restart method again it will. — Kiran Dsouza, Nov 25 '16 at 04:55
Yes, you are correct. onStart() method is not called often. But the onDataChange() method gets called every time a data change occurs. In that time, the data list size goes higher if add without clear existing data in the list. — Madhan, Nov 25 '16 at 05:19

score 0 · Answer 5 · answered Nov 25 '16 at 08:02

Lets say you are instantiating and setting the adapter onCreate() method and initializing your list in onStart(). You should instantiate and set the adapter in onResume() as follows:

public void onResume(){
    super.onResume();
        adapter = new ArrayAdapter<String>
                (this, android.R.layout.simple_list_item_1, dList);
         lvDayList.setAdapter(adapter); 
}

ListView will not populate data from Firebase

5 Answers5