Password strength regex with numbers

Question

I'm working on a strength password test, and I'm trying to check if the password has upper, and lower, case characters. I'm using two regular expressions, and they're almost working; with the code just here:

    var upper = false;
    var lower = false;
    var upperCase= new RegExp('[^A-Z]');
    var lowerCase= new RegExp('[^a-z]');
    


    if (password.match(upperCase )){
        upper = true;    
    }
    if (password.match(lowerCase)){
        lower = true;
    }

When I'm typing numbers, or just a digit, like "1", upper and lower become true.

I'm not really good with regex, did I made a mistake?

`[^...]` is an inverted character class. It matches any character *not* in the set. — melpomene, Nov 27 '16 at 11:09

score 0 · Answer 1 · answered Nov 27 '16 at 11:14

Unless you are paid per line of code; you could simply write:

var upper = password.match(/[A-Z]/);
var lower = password.match(/[a-z]/);

This also fixes the bug in your code where you use [^] which negates the match (aka; your upperCase regexp match non-uppercase chars)

score 0 · Accepted Answer · answered Nov 27 '16 at 11:18

Take a look at the following which uses test to return a Boolean of whether the password contains an upper case and a lower case. You will see how it tests both regexes against various passwords.

    var upperCase= new RegExp('[A-Z]');
    var lowerCase= new RegExp('[a-z]');
    

function test(password) {
    return [ upperCase.test(password), lowerCase.test(password)];
  }

console.log(test("Abc"));
console.log(test("abc"));
console.log(test("123"));

Password strength regex with numbers

2 Answers2