How do I take value of a string leading up to a comma using javascript?

Question

I am attempting to take the city out of a city, state string. For instance, "Portland, OR" would need to equal "Portland". How can I use Javascript or a regular expression to do this?

var myString = "Portland, OR";

I want to extract everything up to the comma but not including the comma.

You should provide sample input and desired output for each it would help a lot. — Nicolas, Nov 30 '16 at 00:09
You might try a regular expression that matches everything from the start of a string that isn't a comma and returns it, or matches everything from the first comma to the end of the string and removes it. — RobG, Nov 30 '16 at 00:11
Just use regex [`^[^,]+`](https://regex101.com/r/wn7A6y/4), this is a very simple question, next time use google... — Nicolas, Nov 30 '16 at 00:13

BrTkCa · Answer 1 · 2016-11-30T00:17:29.430

2

var city = "Portland, OR".split(",")[0];

With regex:

var regex = /^[^,]+/;
var city =  regex.exec("Portland, OR");

edited Nov 30 '16 at 00:17

answered Nov 30 '16 at 00:09

BrTkCa

4,703
3
24
45

1

Works, not very efficient though. – Stephan Bijzitter Nov 30 '16 at 00:10
1

The easyiest way in the provided string. In other case, regex can be the best. – BrTkCa Nov 30 '16 at 00:12
@LucasCosta Give this examle with regex too) thanks – pwnz22 Nov 30 '16 at 00:13
Edited with regex @pwnz22 – BrTkCa Nov 30 '16 at 00:17

Tolgahan Albayrak · Answer 2 · 2016-11-30T00:20:55.467

2

This is the regex version

var result = myString.match(/^[^,]+/)

UPDATE

This one always returns a value without error

var result = String(myString || "").match(/^[^,]*/)[0]

edited Nov 30 '16 at 00:20

answered Nov 30 '16 at 00:13

Tolgahan Albayrak

3,118
1
25
28

Is there an advantage to using Regex over the split or substr methods? – Mjuice Nov 30 '16 at 00:14
in your case "no", for all other cases maybe – Tolgahan Albayrak Nov 30 '16 at 00:14
Splitting is easy to read, but will always be either as fast, or slower than any alternative. As such, regex or substring will always be better than splitting a string for this purpose. – Stephan Bijzitter Nov 30 '16 at 00:15
That will return an array or null, perhaps `myString.match(/^[^,]+/) || [''])[0]` which will return the matched part or empty string if there is no match. – RobG Nov 30 '16 at 00:15
@RobG this one always returns non empty array except string is empty. I will update the answer for that case – Tolgahan Albayrak Nov 30 '16 at 00:19

How do I take value of a string leading up to a comma using javascript?

2 Answers2