mysqli_query doesnt seem to execute correctly

Question

This one has had me stumped for a couple of days. I have a basic PHP script to submit a user registration form. I just cant see what I am doing wrong in this instance the web server is running PHP 7.0 and there are no errors in the logs.

<?php
require_once('connect.php');
if(isset($_POST) && !empty($_POST)){
    $username = mysqli_real_escape_string($connection, $_POST['username']);
    $email = mysqli_real_escape_string($connection, $_POST['email']);
    $password =md5($_POST['password']);

    $sql = "INSERT INTO 'login' (username, email, password) VALUES ('$username', '$email', '$password')";
    $result = mysqli_query($connection, $sql);
    if($result){
        echo "User Rego Secusseflllgk";
    }else{
        echo "User rego faile";
    }
}
?>

I saw a couple of these already but they seemed to be to do with using both myslq and mysqli and others appeared to not be first connection to the DB. Any help would be much appreciated. I am recieving the User Rego Failed echo

`if(mysqli_query($connection, $sql)){ echo "User Rego Secusseflllgk"; }else{ echo "query error".mysqli_error($connection); }`also remove `'` around `login` . Use back-ticks there — Alive to die - Anant, Dec 06 '16 at 10:18
**1.** You shouldn't use `md5`, look into usage of `password_hash()` instead. **2.** You're already using MySQLi, learn how to use *prepared statements*. — Qirel, Dec 06 '16 at 10:19
Also, your code is vulnerable for SQL injection. Use a prepared statement instead. — Thoaren, Dec 06 '16 at 10:21
Thanks Qirel, definitely won't go into production running md5 but thanks for the heads up — Zach Newton, Dec 06 '16 at 10:22

Federkun · Accepted Answer · 2016-12-06T10:22:32.243

1

You probably want use the backtick ` instead of a single quote ' to wrap your table name.

INSERT INTO `login`

When a query fail, it's useful to print the error message. You can do it with mysqli_error:

echo mysqli_error($connection);

edited Dec 06 '16 at 10:22

answered Dec 06 '16 at 10:17

Federkun

36,084
8
78
90

1

`\`` is a backtick, `~` is a tilde btw ;-) – Qirel Dec 06 '16 at 10:20
Thanks Federkun, I didn't even notice the difference between the backtick and ', haha still looking for it on my keyboard. Plus thanks for the advice with printing the error – Zach Newton Dec 06 '16 at 10:20
1

damn @Qirel, I always mix up them, thanks – Federkun Dec 06 '16 at 10:23

score 0 · Answer 2 · answered Dec 06 '16 at 10:17

0

Use table name without single quote and try to check mysqli error with mysqli_error($connection) just after $result.

answered Dec 06 '16 at 10:17

Arnab

4,216
2
28
50

mysqli_query doesnt seem to execute correctly

2 Answers2