How can I continues map function after if statement in Rails?

Question

This is my code:

jobs.map do |record|
  [
    record.id,
    record.jobtitle,
    record.date,
    if (record.expired) then
      "expired"
    else
      "available"
    end
    ,
    record.views_count
  ]

but it show error: syntax error, unexpected ',', expecting ']' How can I do? Thanks for any help because i'm beginer.

score 1 · Answer 1 · edited May 23 '17 at 12:09

1

You could use a ternary statement instead:

jobs.map do |record|
  [
    record.id,
    record.jobtitle,
    record.date,
    (record.expired ? "expired" : "available"),
    record.views_count
  ]

How do I use the conditional operator (? :) in Ruby?

edited May 23 '17 at 12:09

Community

1
1

answered Dec 06 '16 at 18:14

Godwin

9,739
6
40
58

Thanks you very much! – Avada Kedavra Dec 06 '16 at 18:15

score 1 · Answer 2 · answered Dec 06 '16 at 18:15

Remove the 'then' in your if/else statement. Using 'then' is more for clarity on one-liner if statements. Also, move that if/else statement outside of the array. So:

jobs.map do |record|
    if (record.expired)
      x = "expired"
    else
      x = "available"
    end
  [
    record.id,
    record.jobtitle,
    record.date,
    x,
    record.views_count
  ]

If you like one-liners you can use the ternary operator ? for if/else such as: record.expired ? x='expired' : x='available'

Thanks you very much! :D – Avada Kedavra Dec 06 '16 at 18:22 — Avada Kedavra, Dec 06 '16 at 18:22

score 1 · Answer 3 · answered Jan 26 '17 at 11:38

I noticed this from Godwin's response, all you need is the brackets.

jobs.map do |record|
  [
    record.id,
    record.jobtitle,
    record.date,
    (if (record.expired) then
      "expired"
    else
      "available"
    end)
    ,
    record.views_count
  ]

Worked for me, hope that helps.

How can I continues map function after if statement in Rails?

3 Answers3