Uncaught Syntax error on onClick function javascript

Question

I need to output some strings in the onclick anchor function.I have used proper escaping but anyhow its returning error.

My code is:

$output .= '<a title="Minus this" href="#" onclick = removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ');></a>';

And also used this :

$output .= '<a title="Minus this" href="#" onclick = "removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ')"></a>';

But in both cases there is Uncaught SyntaxError: Unexpected token }

Can you kindly check my answer again? I had updated immediately. — Praveen Kumar Purushothaman, Dec 09 '16 at 07:07

score 0 · Answer 1 · answered Dec 09 '16 at 06:49

0

You should use single quotations to represent string in HTML element

$output .= '<a title="Minus this" href="#" onclick = "removefromCart(\'' . $item . '\', \'' . $nonce . '\', ' . $deductQty . ')"></a>';

answered Dec 09 '16 at 06:49

Thum Choon Tat

1

Even single quotes are allowed in HTML. `:)` Just FYI. – Praveen Kumar Purushothaman Dec 09 '16 at 06:53

score 0 · Accepted Answer · edited May 23 '17 at 12:13

0

The quotes is totally wrong. Do this way, using the first one:

$output .= '<a title="Minus this" href="#" onclick=\'removefromCart("' . $item . '", "' . $nonce . '", ' . $deductQty . ');\'></a>';

See the 's I have added and removed spaces? And please, next time, don't mingle both PHP and JavaScript. It's confusingly dangerous.

See also:

edited May 23 '17 at 12:13

Community

answered Dec 09 '16 at 06:49

Not works! `Parse error: syntax error, unexpected 'removefromCart' ` – desiDesign Dec 09 '16 at 06:59
@desiDesign My mistake. Updated. Check now. – Praveen Kumar Purushothaman Dec 09 '16 at 07:00

score 0 · Answer 3 · answered Dec 09 '16 at 06:55

0

For greater than or equal to PHP5

$output .= '<a title="Minus this" href="#" onclick = removefromCart($item,$nonce,$deductQty);></a>';

For Less than PHP5 try it

$output .= '<a title="Minus this" href="#" onclick = removefromCart(' . $item . ',' . $nonce . ', ' . $deductQty . ');></a>';

answered Dec 09 '16 at 06:55

Hikmat Sijapati

2nd one comes like this in inspect : `onclick="removefromCart(9452902fb2661d341204550e807a1442,6c9864b056,"` – desiDesign Dec 09 '16 at 07:03

3 Answers3