Loop with modulus gives me an error

Question

this is my first time posting a question, but this loop drove me crazy. I cant figure out what is wrong with it. It crashes at the moment when it enters the second loop. It looks fine and makes sense but still it does not work. Any help will be greatly appreciated. Thanks!

/**
Author: Yunus Kulyyev
Date: 10-Dec-2016
Description:
**/

#include <iostream>

using namespace std;

int main()
{
    for (int x=1; x < 10; x++)
    {
        cout << x <<": ";
        for (int y = 0; y <= x; y++)
        {
            if (x%y == 0)
            {
            cout << y;
            }
        }
        cout << endl;
    }

    return 0;
}

On the first iteration, when `y==0`, what do you expect would be the value of `x % y`? — Igor Tandetnik, Dec 11 '16 at 04:39

score 2 · Accepted Answer · edited May 23 '17 at 10:30

2

If the second operand of / or % is zero, then the behavior is undefined. See this post in SO. In your program, for the first iteration of the inner for loop, y = 0 and thus the following code snippet results in undefined behavior.

if (x%y == 0) {
    cout << y;
}

edited May 23 '17 at 10:30

Community

1
1

answered Dec 11 '16 at 04:45

Wasi Ahmad

35,739
32
114
161

@YunusKulyyev best way to thank is accepting the answer :) – Wasi Ahmad Dec 11 '16 at 05:04
@YunusKulyyev you can accept my answer if it helped you. – Wasi Ahmad Dec 11 '16 at 05:26

Loop with modulus gives me an error

1 Answers1