How to use save Mute/Unmute Button?

Question

Hi I have been researching a lot about this issue but i couldn't find the best solution of my problem.

So the problem is that my background music starts playing.I have got two buttons."On" and "Off". I want to mute the music so when i click my mute button,it from "On" goes to "Off" and the music stops.But when i change the scene and go back it returns to the button with the text "On" but the music is still stopped. So my question is only how to save the changed button without going back by default? Here is my script:

public GameObject on;
public GameObject off;
public string sound;

Soundtrack music;
static bool isMuted;


void Awake()
{
    SoundCheck();


}
void Start()
{
    music = FindObjectOfType<Soundtrack>();
}
public void Off()
{
    if (isMuted == false)
     {
    on.gameObject.SetActive(false);
    off.gameObject.SetActive(true);
    music.s.Stop();
    isMuted = true;
    PlayerPrefs.SetString("Sound", "muted");
     }
}
public void On()
{    if(isMuted==true)
   {
    on.gameObject.SetActive(true);
    off.gameObject.SetActive(false);
    music.s.Play();
    isMuted = false;
    PlayerPrefs.SetString("Sound", "enabled");
   }
}
public void SoundCheck()
{
    sound = PlayerPrefs.GetString("Sound");

    if (sound == "enabled")
    {
        isMuted = false;
    }
    else if (sound == "muted")
    {
        isMuted = true;
    }
}

}

Perhaps not related to the problem at hand, but it looks like you've got a big problem with your if statements: multi-line code you want executed in the if statement should be enclosed in curly braces - otherwise, only the first line after the if statement will be conditionally executed. For example, in `Off()`, the only line that will be conditionally executed will be `on.gameObject.SetActive(false);`. The rest of the lines will be executed every time the method is called, no matter what. I recommend you get in the habit of writing curly braces with every if statement you write. — Serlite, Dec 12 '16 at 02:34
Oh yeah i knew that. It doesn't work either when i put the curly braces on the whole code in the function.Now i must have inadvertently just erased them while writing this post.But thanks for your attention :) .Now i will correct it for future readers. — Abdu Omar, Dec 12 '16 at 02:38
Looks like a duplicate. Please look [here](http://stackoverflow.com/a/41073496/3785314) — Programmer, Dec 12 '16 at 07:24

score 0 · Accepted Answer · answered Dec 12 '16 at 07:09

0

it's easy. First of all it's much better to save bool type in your PlayerPrefs instead ofstring. But to solve your issue all you have to do it's add is

public void SoundCheck() { sound = PlayerPrefs.GetString("Sound"); if (sound == "enabled") { isMuted = false; } else if (sound == "muted") { isMuted = true; } on.gameObject.SetActive(isMuted); off.gameObject.SetActive(!isMuted); }

answered Dec 12 '16 at 07:09

zhekazheka

111
4

What about the "on" and "off" functions? – Abdu Omar Dec 12 '16 at 07:20
Should I change anything from them? – Abdu Omar Dec 12 '16 at 07:27
If you would change your PlayerPrefs type from 'string' to 'bool' then you will have to modify it, but rather than that no. – zhekazheka Dec 12 '16 at 07:29
Help me with the code then.How to make them to bool? – Abdu Omar Dec 12 '16 at 07:31
Use PlayerPrefs.SetBool instead is SetString and as value pass isMuted variable. Sorry it's hard to type code on a phone. – zhekazheka Dec 12 '16 at 07:34
There is no `PlayerPrefs.SetBool`. Read my comment under your question. – Programmer Dec 12 '16 at 07:35
Yes i saw your comment – Abdu Omar Dec 12 '16 at 07:36
Sorry, of course, you have to use SetInt/GetInt with value greater than zero if isMuted true. – zhekazheka Dec 12 '16 at 07:37
Anyway, to solve your issue you can just add this two lines of code to SoundCheck, which I posted. – zhekazheka Dec 12 '16 at 07:38
It worked but just correct your code for future readers.Just in "on" is !isMuted and in"off" is Muted – Abdu Omar Dec 12 '16 at 07:47

score 0 · Answer 2 · answered Dec 12 '16 at 07:45

0

You need change SoundCheck() call in Start function not Awake! the Start() will call when you back the scence,but Awake not.

Btw:

Should bool for save PlayerPrefs,
Think a button and change sprite to Sprite On and Sprite Off can better.

answered Dec 12 '16 at 07:45

Geo Wesley

103
8

How to use save Mute/Unmute Button?

2 Answers2