Change drawable color in menu

Question

I have created a popup menu and inside the popup.xml, I have two icons. I trying to change the color of icon inside the popup.xml but the color always remains white (original color).

Is there a way to change the drawable color in menu ?

popup.xml

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android">
    <item
        android:id="@+id/opt1"
        android:icon="@drawable/change_pic"
        android:color="@color/green"
        android:title="Change Picture" />
    <item
        android:id="@+id/opt2"
        android:icon="@drawable/change_pin"
        android:title="Change Password" />
</menu>

ScreenShot

Code

  @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        getMenuInflater().inflate(R.menu.add_task, menu); // for the two icons in action bar
        return true;
    }

    @Override
        public boolean onOptionsItemSelected(MenuItem item) {
            switch (item.getItemId()) {

                case R.id.menu:
                    View menuItemView = findViewById(R.id.menu);
                    MenuBuilder menuBuilder =new MenuBuilder(this);
                    MenuInflater inflater = new MenuInflater(this);
                    inflater.inflate(R.menu.popup, menuBuilder);
                    MenuPopupHelper optionsMenu = new MenuPopupHelper(this, menuBuilder, menuItemView);
                    optionsMenu.setForceShowIcon(true);
                    optionsMenu.show();

                default:
                    return super.onOptionsItemSelected(item);
            }
        }

As you can see, the image is actually white color.

Get the drawable from icon menu and apply color filter in that — M D, Dec 14 '16 at 05:59
Are you trying to change the color of your icon - 'change_pic', which is present in drawable folder ? — Swas_99, Dec 14 '16 at 06:01
U will have to add an icon with the color u needto change color — Athul, Dec 14 '16 at 06:06
http://stackoverflow.com/questions/19750635/icon-in-menu-not-showing-in-android — Shayan Pourvatan, Dec 14 '16 at 06:09
U will have add the respective image with respective image manually for changing the icon color — Athul, Dec 14 '16 at 06:10
did you inflate popup as menu ? ( in onCreateOption or onPrepare ) — Shayan Pourvatan, Dec 14 '16 at 06:12
It showing like that because the image u saved in drawable in white — Athul, Dec 14 '16 at 06:13
so see accepted answer in my link : ( If you're running your code on Android 3.0+, the icons in the menu are not shown by design. This is a design decision by Google. ) — Shayan Pourvatan, Dec 14 '16 at 06:21
@shayanpourvatan my mistake...I didn't inflate popup as menu in onCreateOption. I have inflated another menu. — John Joe, Dec 14 '16 at 06:36

Athul · Accepted Answer · 2016-12-14T06:45:04.927

2

Please try this

@Override
    public boolean onOptionsItemSelected(MenuItem item) {
        switch (item.getItemId()) {

            case R.id.menu:
                View menuItemView = findViewById(R.id.menu);
                MenuBuilder menuBuilder =new MenuBuilder(this);
                MenuInflater inflater = new MenuInflater(this);
                inflater.inflate(R.menu.popup, menuBuilder);
 Drawable yourdrawable1 = menuBuilder.getItem(0).getIcon(); // change 0 with 1,2 ... 
            Drawable yourdrawable2 = menuBuilder.getItem(1).getIcon();
            yourdrawable1.mutate();
            yourdrawable2.mutate();
             yourdrawable1.setColorFilter(getResources().getColor(R.color.black), PorterDuff.Mode.SRC_IN);
yourdrawable2.setColorFilter(getResources().getColor(R.color.black), PorterDuff.Mode.SRC_IN);
                MenuPopupHelper optionsMenu = new MenuPopupHelper(this, menuBuilder, menuItemView);
                optionsMenu.setForceShowIcon(true);
                optionsMenu.show();

            default:
                return super.onOptionsItemSelected(item);
        }
    }

edited Dec 14 '16 at 06:45

answered Dec 14 '16 at 06:17

Athul

801
7
16

This will change the color of change pic image – Athul Dec 14 '16 at 06:19
Please try and let me knw – Athul Dec 14 '16 at 06:19
If I use your code, my action bar icon will gone, because I add them in `getMenuInflater().inflate(R.menu.add_task, menu);` – John Joe Dec 14 '16 at 06:33
Updated it ...Tried this way? – Athul Dec 14 '16 at 06:36
Thanks,it works. But if I want to change the second items to green, what is the best approach ? – John Joe Dec 14 '16 at 06:40
change the get Item number – Athul Dec 14 '16 at 06:43
I need to create another Drawable object ? – John Joe Dec 14 '16 at 06:44
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/130577/discussion-between-athul-and-john-joe). – Athul Dec 14 '16 at 06:45
@JohnJoe Did u try? – Athul Dec 14 '16 at 06:47

score 1 · Answer 2 · answered Dec 14 '16 at 06:22

1

change_pic is image file or vector asset file ??? If it is vector asset then you can change the color from .xml file and if you are using image file then i suggest you to use vector asset file.

answered Dec 14 '16 at 06:22

appy

106
1
5

I download from https://material.io/icons/#ic_power_settings_new. Is it consider vector asset file ? – John Joe Dec 14 '16 at 06:24
save it in .svg format and then you can convert it in vector asset.for converting .svg to vector asset go to drawable>>new>>vector asset>>select local file(svg,psd) and then select your .svg file path. – appy Dec 14 '16 at 11:57
It will generate one .xml file.In .xml file you can change the color from android:fillColor="#000000". put your color code. – appy Dec 14 '16 at 11:59

Change drawable color in menu

2 Answers2